[FIX] url click events in the cordova app open in external browser or not at all#7205
Conversation
|
Maybe this PR also fix #5468 ? |
|
@TheReal1604 it should, and this problem mentioned in a comment there:
should be fixed by making this regexp case insensitive Of course, please feel free to test this PR and let me know if everything is ok for you. EDIT: i added a new commit to also fix this. |
|
@flaviogrossi thanks for opening this PR! I know this is an issue that has plagued my self and others for a while now. |
|
This will be awesome to have fixed! |
|
Omg, yes Amazing - Thanks so much Let's get this in a release please :D |
|
@geekgonecrazy - Can we get this popped into the next release? It's a pretty big usability problem and I know the issue has frustrated some of our users to the point where they no longer use RC on mobile. Please 🥇 👍 |
|
@JSzaszvari agreed. We need to get this in. Its very annoying on mobile web even. Hard to click links |
| 'touchmove'(e, t) { | ||
| if (t.touchstartX != null) { | ||
| const [touch] = e.originalEvent.touches; | ||
| const touch = e.originalEvent.touches[0]; |
There was a problem hiding this comment.
Why did you changed that? It isn't the same thing?
There was a problem hiding this comment.
This is needed because it seems that the TouchList object is not iterable on (some?) mobile platforms, thus raising an exception on every scroll event in the cordova app.
More details are here: #7075
geekgonecrazy
left a comment
geekgonecrazy
left a comment
There was a problem hiding this comment.
Tested and confirmed this fixes the issue.
… not at all (RocketChat#7205) * fix url click events in the cordova app fixes RocketChat/Rocket.Chat.Cordova#142 * make urls regexp case insensitive since mobile devices often autocapitalize them
|
Team, can we please ensure this is in the next release? It's a pretty big one that's cause a lot of issues now for nearly a year. |
|
https://github.com/RocketChat/Rocket.Chat/blob/0.58.0-rc.0/packages/rocketchat-ui-master/client/main.js it appears there... But not in release notes.. @rodrigok ideas? |
6 participants
@RocketChat/core
this should fix the following problems:
Please let me know if this also works for you.
Closes RocketChat/Rocket.Chat.Cordova#142 and #7075