[BREAK] Internal hubot does not load hubot-scripts anymore, it loads scripts from custom folders#7095
Merged
sampaiodiego merged 9 commits intodevelopfrom May 31, 2017
Merged
[BREAK] Internal hubot does not load hubot-scripts anymore, it loads scripts from custom folders#7095sampaiodiego merged 9 commits intodevelopfrom
sampaiodiego merged 9 commits intodevelopfrom
Conversation
Member
|
I think we need to add a @RocketChat/core what you think? |
sampaiodiego
requested changes
May 25, 2017
| @@ -0,0 +1,242 @@ | |||
| /* eslint-disable no-use-before-define no-unused-vars */ | |||
Member
There was a problem hiding this comment.
can you fix the issues instead of disabling it?
Contributor
|
@sampaiodiego agreed! If the scripts aren't there and it tries to load them what happens? If hubot breaks badly... then we may want to add a migration that either turns off the internal hubot if scripts that used to be there are referenced... or remove them from the field. |
Member
Author
|
@geekgonecrazy the |
Contributor
|
@ggazzo 👍 ok awesome probably safe to leave then. Actually maybe we can add [Break] separately on the release notes. Since this is a [New] Feature. |
sampaiodiego
approved these changes
May 31, 2017
Syirrus
pushed a commit
to Syirrus/Rocket.Chat
that referenced
this pull request
Jun 5, 2017
…nto clarapy-v4 * 'develop' of https://github.com/RocketChat/Rocket.Chat: (102 commits) Fix forbidden error on setAvatar REST endpoint (RocketChat#7159) Fix migration version Switch logic of artifact name (RocketChat#7158) fix reactions Remove missing CoffeeScript dependencies Update server.js Update server.js Update server.js [FIX] Fix highlightjs bug (RocketChat#6991) Convert hipchat importer to js Convert file unsubscribe.coffee to js Fix migration if email already exists [NEW] Internal Hubot load scripts from custom folders (RocketChat#7095) Unit: Fix mentions tests Unit: Fix mentions tests Fix tests remove the missing coffee files fix eslint Bump Update oauth2-client.js ... # Conflicts: # packages/rocketchat-ui-master/.npm/package/npm-shrinkwrap.json
rodrigok
changed the title
rodrigok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/core