Support for dynamic slack and rocket channels#6282
Support for dynamic slack and rocket channels#6282kable-wilmoth wants to merge 4 commits intoRocketChat:developfrom
Conversation
| connection: 'Connection', | ||
| events: 'Events', | ||
| class: 'Class' | ||
| class: 'Class', |
There was a problem hiding this comment.
Added some more logger sections
| @@ -15,8 +15,13 @@ Package.onUse(function(api) { | |||
|
|
|||
| api.addFiles('logger.js', 'server'); | |||
| api.addFiles('settings.js', 'server'); | |||
There was a problem hiding this comment.
Broke up the logic from slackbridge into rocket specific and slack specific files
| api.addFiles('slack.js', 'server'); | ||
| api.addFiles('slackbridge.js', 'server'); | ||
| api.addFiles('slashcommand/slackbridge_import.server.js', 'server'); | ||
|
|
There was a problem hiding this comment.
Exporting the objects from Rocket and Slack JS files so they could see each other
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
This seemed the most appropriate way to resolve 'require/dependency' so the two JS files could see each other
| } | ||
|
|
||
| } | ||
|
|
There was a problem hiding this comment.
This seemed the most appropriate way to resolve 'require/dependency' so the two JS files could see each other
| @@ -0,0 +1,58 @@ | |||
| Config: | |||
There was a problem hiding this comment.
I do not know how to implement unit tests inside Rock.Chat yet so I need to keep a script of manual tests I need to run each time
|
Will be updating to use import/export tomorrow |
kable-wilmoth
force-pushed
the
DynamicGroups
branch
from
3129a57 to
c078d13
Compare
kable-wilmoth
force-pushed
the
DynamicGroups
branch
from
c078d13 to
6b237ee
Compare
4 participants
@RocketChat/core
The goal of this pull request was to support Slack and Rocket channels coming and going. You had to enable/disable the slack bridge for it to pick up on changes.
Refactored the code into multiple files to allow for easier contributions in the future.
Fixed a 'not defined' error that was polluting the server logs
Improved logging/debugging messages some more