fix: third-party login is broken#39534
Merged
dionisio-bot[bot] merged 1 commit intorelease-7.10.9from Mar 12, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 019378e The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/meteor/app/oauth2-server-config/server/oauth/oauth2-server.ts">
<violation number="1" location="apps/meteor/app/oauth2-server-config/server/oauth/oauth2-server.ts:80">
P2: Avoid the unsafe cast on `queryParams`; it can hide non‑string values (like string arrays) and cause `getAccessToken` to receive a non‑string token. Narrow `access_token` to a string before passing it through.
(Based on your team's feedback about avoiding unsafe type casts.) [FEEDBACK_USED]</violation>
</file>
<file name="apps/meteor/lib/utils/isPlainObject.ts">
<violation number="1" location="apps/meteor/lib/utils/isPlainObject.ts:1">
P2: The type predicate is too narrow for the current runtime check. The function returns true for non-plain objects (e.g., `Date`, class instances), but the signature says it narrows to `Record<string | symbol, unknown>`, which isn’t guaranteed. Use a broader predicate or tighten the runtime check to match a plain-object shape.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.10.9 #39534 +/- ##
=================================================
Coverage ? 66.39%
=================================================
Files ? 3306
Lines ? 111042
Branches ? 21007
=================================================
Hits ? 73727
Misses ? 34581
Partials ? 2734
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ricardogarim
approved these changes
Mar 12, 2026
ricardogarim
added
the
stat: QA assured
Contributor
Author
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #37707