fix: third-party login is broken#39533
Merged
dionisio-bot[bot] merged 1 commit intorelease-7.11.6from Mar 11, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 9fdd90d The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/meteor/app/api/server/helpers/parseJsonQuery.ts">
<violation number="1" location="apps/meteor/app/api/server/helpers/parseJsonQuery.ts:31">
P1: Defaulting `queryFields`/`queryOperations` to `[]` changes validation semantics and can reject valid queries that previously passed. Preserve `undefined` when those route settings are not provided.</violation>
</file>
<file name="apps/meteor/lib/utils/isPlainObject.ts">
<violation number="1" location="apps/meteor/lib/utils/isPlainObject.ts:1">
P2: The new type predicate is unsound for this runtime check: it narrows any non-array object to `Record<string | symbol, unknown>`, including `Date`, `Map`, and class instances.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
ricardogarim
approved these changes
Mar 11, 2026
ricardogarim
added
the
stat: QA assured
Contributor
Author
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.11.6 #39533 +/- ##
=================================================
Coverage ? 67.57%
=================================================
Files ? 3347
Lines ? 114073
Branches ? 20820
=================================================
Hits ? 77081
Misses ? 34352
Partials ? 2640
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #37707