fix: third-party login is broken#39523
Conversation
🦋 Changeset detectedLatest commit: 069b3c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
2 issues found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/meteor/app/api/server/helpers/parseJsonQuery.ts">
<violation number="1" location="apps/meteor/app/api/server/helpers/parseJsonQuery.ts:31">
P1: Defaulting `queryFields` to `[]` changes behavior and rejects queries on routes that do not define `queryFields`. Keep it `undefined` when absent so the existing validation gate remains correct.</violation>
<violation number="2" location="apps/meteor/app/api/server/helpers/parseJsonQuery.ts:32">
P1: Defaulting `queryOperations` to `[]` disables the intended fallback operator allowlist. Use `undefined` for missing route config so `pathAllowConf.def` is still applied.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
a746ad9 to
069b3c6
Compare
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.13.5 #39523 +/- ##
=================================================
Coverage ? 67.80%
=================================================
Files ? 3445
Lines ? 113917
Branches ? 20837
=================================================
Hits ? 77244
Misses ? 34563
Partials ? 2110
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #37707