Skip to content

fix: third-party login is broken#39523

Merged
dionisio-bot[bot] merged 1 commit intorelease-7.13.5from
backport-7.13.5-37707
Mar 11, 2026
Merged

fix: third-party login is broken#39523
dionisio-bot[bot] merged 1 commit intorelease-7.13.5from
backport-7.13.5-37707

Conversation

@dionisio-bot
Copy link
Copy Markdown
Contributor

@dionisio-bot dionisio-bot bot commented Mar 10, 2026

Backport of #37707

@dionisio-bot dionisio-bot bot requested a review from a team as a code owner March 10, 2026 19:46
@dionisio-bot dionisio-bot bot requested a review from d-gubert March 10, 2026 19:46
@dionisio-bot dionisio-bot bot added the backport Used to inform backported PR label Mar 10, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 10, 2026

🦋 Changeset detected

Latest commit: 069b3c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 10 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/meteor/app/api/server/helpers/parseJsonQuery.ts">

<violation number="1" location="apps/meteor/app/api/server/helpers/parseJsonQuery.ts:31">
P1: Defaulting `queryFields` to `[]` changes behavior and rejects queries on routes that do not define `queryFields`. Keep it `undefined` when absent so the existing validation gate remains correct.</violation>

<violation number="2" location="apps/meteor/app/api/server/helpers/parseJsonQuery.ts:32">
P1: Defaulting `queryOperations` to `[]` disables the intended fallback operator allowlist. Use `undefined` for missing route config so `pathAllowConf.def` is still applied.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 10, 2026

📦 Docker Image Size Report

📉 Changes

Service Current Baseline Change Percent
sum of all images 0B 1.2GiB -1.2GiB
account-service 0B 117MiB -117MiB
authorization-service 0B 114MiB -114MiB
ddp-streamer-service 0B 130MiB -130MiB
omnichannel-transcript-service 0B 135MiB -135MiB
presence-service 0B 114MiB -114MiB
queue-worker-service 0B 135MiB -135MiB
rocketchat 0B 332MiB -332MiB
stream-hub-service 0B 111MiB -111MiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/29 19:01", "12/30 20:52", "02/12 22:57", "02/13 22:38", "02/16 14:04", "02/18 23:15", "02/19 23:23", "02/20 22:25", "02/21 04:30", "02/22 19:30", "02/23 23:33", "02/24 23:28", "02/25 22:56", "02/26 23:19", "02/27 23:23", "02/28 01:10", "03/02 21:21", "03/03 23:59", "03/04 23:10", "03/05 21:16", "03/06 22:50", "03/07 05:18", "03/09 20:47", "03/10 22:45", "03/11 00:06 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "omnichannel-transcript-service" [0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.00]
  line "queue-worker-service" [0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.00]
  line "rocketchat" [0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.33, 0.33, 0.33, 0.33, 0.33, 0.33, 0.33, 0.33, 0.33, 0.33, 0.00]
  line "stream-hub-service" [0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00, 0.00]
Loading

Statistics (last 30 days):

  • 📊 Average: 1.4GiB
  • ⬇️ Minimum: 1.4GiB
  • ⬆️ Maximum: 1.5GiB
  • 🎯 Current PR: 0B
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-39523
  • Baseline: develop
  • Timestamp: 2026-03-11 00:06:51 UTC
  • Historical data points: 30

Updated: Wed, 11 Mar 2026 00:06:51 GMT

@d-gubert d-gubert force-pushed the backport-7.13.5-37707 branch from a746ad9 to 069b3c6 Compare March 10, 2026 23:34
@dionisio-bot
Copy link
Copy Markdown
Contributor Author

dionisio-bot bot commented Mar 10, 2026

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@ricardogarim ricardogarim added the stat: QA assured Means it has been tested and approved by a company insider label Mar 11, 2026
@dionisio-bot dionisio-bot bot merged commit 261ad5e into release-7.13.5 Mar 11, 2026
81 of 85 checks passed
@dionisio-bot dionisio-bot bot deleted the backport-7.13.5-37707 branch March 11, 2026 01:07
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-7.13.5@cd30b57). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-7.13.5   #39523   +/-   ##
=================================================
  Coverage                  ?   67.80%           
=================================================
  Files                     ?     3445           
  Lines                     ?   113917           
  Branches                  ?    20837           
=================================================
  Hits                      ?    77244           
  Misses                    ?    34563           
  Partials                  ?     2110           
Flag Coverage Δ
e2e 57.45% <ø> (?)
e2e-api 42.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Used to inform backported PR community stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants