fix(apps): prevent installation invalidation on app cron updates#39516
Merged
dionisio-bot[bot] merged 1 commit intorelease-7.12.6from Mar 11, 2026
Merged
fix(apps): prevent installation invalidation on app cron updates#39516dionisio-bot[bot] merged 1 commit intorelease-7.12.6from
dionisio-bot[bot] merged 1 commit intorelease-7.12.6from
Conversation
🦋 Changeset detectedLatest commit: ff5a755 The changes in this PR will be included in the next version bump. This PR includes changesets to release 42 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/apps-engine/src/server/AppManager.ts">
<violation number="1" location="packages/apps-engine/src/server/AppManager.ts:941">
P1: Keeping scheduled jobs here lets an `INVALID_LICENSE_DISABLED` app continue running its cron processors.</violation>
</file>
<file name="packages/apps-engine/tests/server/AppManager.spec.ts">
<violation number="1" location="packages/apps-engine/tests/server/AppManager.spec.ts:138">
P2: Stub `validateLicense()` for the mock apps in these skip-path tests. `updateAppsMarketplaceInfo()` always runs a second validation pass over `manager.apps`, so the current setup still hits unimplemented bridge methods and logs errors even when the update path is skipped.
(Based on your team's feedback about mocking only dependencies that affect observable side effects.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
d-gubert
force-pushed
the
backport-7.12.6-37152
branch
from
d215be7 to
7261206
Compare
Contributor
Author
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
d-gubert
force-pushed
the
backport-7.12.6-37152
branch
from
7261206 to
fb8f8b2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-7.12.6 #39516 +/- ##
=================================================
Coverage ? 66.62%
=================================================
Files ? 3409
Lines ? 116436
Branches ? 21470
=================================================
Hits ? 77578
Misses ? 36153
Partials ? 2705
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
d-gubert
force-pushed
the
backport-7.12.6-37152
branch
from
fb8f8b2 to
ff5a755
Compare
d-gubert
approved these changes
Mar 11, 2026
d-gubert
added
the
stat: QA assured
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #37152