chore: migrate `removeInvite/:_id` endpoint to chained API pattern with AJV validation by NAME-ASHWANIYADAV · Pull Request #39200 · RocketChat/Rocket.Chat

NAME-ASHWANIYADAV · 2026-02-28T19:01:38Z

Closes #39199

Changes

Migrated removeInvite/:_id DELETE endpoint from legacy API.v1.addRoute to the new chained .delete() API pattern
Added AJV response schema validation for the 200 response
Removed manual '/v1/removeInvite/:_id' type definition from rest-typings (now auto-inferred via ExtractRoutesFromAPI)

Files Changed

apps/meteor/app/api/server/v1/invites.ts — endpoint migration
packages/rest-typings/src/v1/invites.ts — removed manual type definition

No behavioral changes

The endpoint logic remains identical — only the registration pattern has been updated.

Related project

This continues the REST API migration effort described in the GSoC 2026 project: Replace old REST API definitions over the new API.

cc @diego-sampaio @ggazzo

Summary by CodeRabbit

API Changes
- The removeInvite endpoint type definition was removed from the public API surface.
Internal Improvements
- Invite endpoint implementation structure and route declaration were reorganized (no change to runtime behavior).

… AJV validation

dionisio-bot · 2026-02-28T19:01:42Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2026-02-28T19:01:43Z

⚠️ No Changeset found

Latest commit: 7cb0714

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-02-28T19:02:12Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 650aaa6a-8469-49ed-b6ec-b70513d202f3

📥 Commits

Reviewing files that changed from the base of the PR and between a7207d4 and 3da4b4d.

📒 Files selected for processing (1)

apps/meteor/app/api/server/v1/invites.ts

🚧 Files skipped from review as they are similar to previous changes (1)

apps/meteor/app/api/server/v1/invites.ts

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: cubic · AI code reviewer

Walkthrough

Migrates the removeInvite endpoint from the deprecated API.v1.addRoute pattern to the new chained .delete() API pattern with AJV validation schema support. Removes the corresponding type declaration from the public API typings.

Changes

Cohort / File(s)	Summary
API Route Migration `apps/meteor/app/api/server/v1/invites.ts`	Replaces legacy `API.v1.addRoute` with chained `.delete()` pattern for `removeInvite/:_id` endpoint. Adds response schema validation for 200 status returning boolean, maintains auth requirement and handler logic.
Type Declaration Removal `packages/rest-typings/src/v1/invites.ts`	Removes the `'/v1/removeInvite/:_id': { DELETE: () => boolean; };` type declaration from the `InvitesEndpoints` interface.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: migrating the removeInvite endpoint from legacy API pattern to chained pattern with AJV validation, which aligns with the changeset.
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue `#39199`: migrates the removeInvite endpoint to chained .delete() pattern, adds AJV response validation, and removes the manual type definition from rest-typings.
Out of Scope Changes check	✅ Passed	All changes are directly related to the migration objective; modifications to invites.ts endpoint implementation and removal of the manual type definition from rest-typings are both in-scope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

No issues found across 2 files

ggazzo · 2026-03-23T19:24:44Z

Hey, thanks for the contribution! 🙏

I'm closing this PR because the endpoint(s) covered here have already been migrated as part of a larger batch migration I'm working on (see #39820). I decided to go with a mass migration approach because reviewing individual PRs for each endpoint was taking too much of my time.

That said, you're more than welcome to help by reviewing and testing the changes in #39820 to make sure everything is working correctly. Your input would be really valuable!

Thanks again for your effort! 🚀

NAME-ASHWANIYADAV · 2026-03-23T19:35:28Z

Thanks for the heads up @ggazzo ! Totally understand the batch approach. FYI, I've also opened #39819 which migrates livechat/agent.info and livechat/agent.next endpoints — in case those aren't already covered in #39820. Happy to help review and test your batch PR too!

chore: migrate removeInvite/:_id endpoint to chained API pattern with…

a7207d4

… AJV validation

NAME-ASHWANIYADAV requested review from a team as code owners February 28, 2026 19:01

cubic-dev-ai bot reviewed Feb 28, 2026

View reviewed changes

coderabbitai bot added the type: chore label Feb 28, 2026

ahmed-n-abdeltwab mentioned this pull request Mar 1, 2026

[NOMERGE] feat: openapi migration progress RocketChat/Rocket.Chat-Open-API#150

Draft

fix: resolve eslint warnings in invites.ts

3da4b4d

dionisio-bot bot added the community label Mar 10, 2026

Merge branch 'develop' into chore/migrate-removeInvite-openapi

7cb0714

ggazzo closed this Mar 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate `removeInvite/:_id` endpoint to chained API pattern with AJV validation#39200

chore: migrate `removeInvite/:_id` endpoint to chained API pattern with AJV validation#39200
NAME-ASHWANIYADAV wants to merge 3 commits intoRocketChat:developfrom
NAME-ASHWANIYADAV:chore/migrate-removeInvite-openapi

NAME-ASHWANIYADAV commented Feb 28, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

dionisio-bot bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

ggazzo commented Mar 23, 2026

Uh oh!

NAME-ASHWANIYADAV commented Mar 23, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

NAME-ASHWANIYADAV commented Feb 28, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Files Changed

No behavioral changes

Related project

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

ggazzo commented Mar 23, 2026

Uh oh!

NAME-ASHWANIYADAV commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NAME-ASHWANIYADAV commented Feb 28, 2026 •

edited by coderabbitai bot

Loading

dionisio-bot bot commented Feb 28, 2026 •

edited

Loading

changeset-bot bot commented Feb 28, 2026 •

edited

Loading

coderabbitai bot commented Feb 28, 2026 •

edited

Loading

NAME-ASHWANIYADAV commented Mar 23, 2026 •

edited

Loading