Skip to content

chore(eslint): Upgrade ESLint configuration#38989

Merged
ggazzo merged 26 commits intodevelopfrom
chore/eslint-upgrade
Feb 27, 2026
Merged

chore(eslint): Upgrade ESLint configuration#38989
ggazzo merged 26 commits intodevelopfrom
chore/eslint-upgrade

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Feb 24, 2026 •
edited
Loading

Proposed changes (including videos or screenshots)

It upgrades ESLint to version 9 and adapts its configuration.

Issue(s)

Task: ARCH-1989
Related tasks: CORE-1212

Steps to test or reproduce

Further comments

This requires considerable adjustments because: (1) default configurations have expanded, (2) rules have changed in scope and options, and (3) some rules are now autofixable. Code corrections to adhere to these changes will be addressed in subsequent pull requests.

✖ 4823 problems (0 errors, 4823 warnings)
  0 errors and 559 warnings potentially fixable with the `--fix` option.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 24, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: c7c7b8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 73 packages
Name Type
@rocket.chat/eslint-config Minor
@rocket.chat/server-cloud-communication Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/authorization-service Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/network-broker Patch
@rocket.chat/password-policies Patch
@rocket.chat/release-changelog Patch
@rocket.chat/storybook-config Patch
@rocket.chat/presence-service Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/instance-status Patch
@rocket.chat/media-signaling Patch
@rocket.chat/patch-injection Patch
@rocket.chat/account-service Patch
@rocket.chat/media-calls Patch
@rocket.chat/message-parser Patch
@rocket.chat/mock-providers Patch
@rocket.chat/release-action Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/ui-theming Patch
@rocket.chat/account-utils Patch
@rocket.chat/core-services Patch
@rocket.chat/message-types Patch
@rocket.chat/model-typings Patch
@rocket.chat/mongo-adapter Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/cas-validate Patch
@rocket.chat/core-typings Patch
@rocket.chat/jest-presets Patch
@rocket.chat/peggy-loader Patch
@rocket.chat/rest-typings Patch
@rocket.chat/server-fetch Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/queue-worker Patch
@rocket.chat/presence Patch
@rocket.chat/apps-engine Patch
@rocket.chat/desktop-api Patch
@rocket.chat/http-router Patch
@rocket.chat/poplib Patch
@rocket.chat/ui-composer Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/license Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/log-format Patch
@rocket.chat/gazzodown Patch
@rocket.chat/omni-core Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/livechat Patch
@rocket.chat/abac Patch
@rocket.chat/favicon Patch
@rocket.chat/tracing Patch
@rocket.chat/ui-voip Patch
@rocket.chat/agenda Patch
@rocket.chat/base64 Patch
@rocket.chat/logger Patch
@rocket.chat/models Patch
@rocket.chat/random Patch
@rocket.chat/sha256 Patch
@rocket.chat/ui-kit Patch
@rocket.chat/tools Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/i18n Patch
@rocket.chat/jwt Patch
@rocket.chat/meteor Patch
rocketchat-services Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Feb 24, 2026 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 24, 2026 •
edited
Loading

Important

Review skipped

Too many files!

This PR contains 163 files, which is 13 over the limit of 150.

📥 Commits

Reviewing files that changed from the base of the PR and between b4b9303 and c7c7b8a.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (163)
  • .changeset/little-eyes-kneel.md
  • .github/workflows/ci-code-check.yml
  • .vscode/settings.json
  • apps/meteor/.eslintrc.json
  • apps/meteor/package.json
  • apps/meteor/packages/.eslintrc.json
  • apps/meteor/packages/rocketchat-i18n/.eslintrc.json
  • apps/meteor/tests/e2e/.eslintrc.json
  • apps/uikit-playground/.eslintrc.json
  • apps/uikit-playground/package.json
  • ee/apps/account-service/.eslintrc.json
  • ee/apps/account-service/package.json
  • ee/apps/authorization-service/.eslintrc.json
  • ee/apps/authorization-service/package.json
  • ee/apps/ddp-streamer/.eslintrc.json
  • ee/apps/ddp-streamer/package.json
  • ee/apps/omnichannel-transcript/.eslintrc.json
  • ee/apps/omnichannel-transcript/package.json
  • ee/apps/presence-service/.eslintrc.json
  • ee/apps/presence-service/package.json
  • ee/apps/queue-worker/.eslintrc.json
  • ee/apps/queue-worker/package.json
  • ee/packages/abac/.eslintrc.json
  • ee/packages/abac/package.json
  • ee/packages/federation-matrix/.eslintrc.json
  • ee/packages/federation-matrix/package.json
  • ee/packages/license/.eslintrc.json
  • ee/packages/license/package.json
  • ee/packages/media-calls/.eslintrc.json
  • ee/packages/media-calls/package.json
  • ee/packages/network-broker/.eslintrc.json
  • ee/packages/network-broker/package.json
  • ee/packages/omni-core-ee/.eslintrc.json
  • ee/packages/omni-core-ee/package.json
  • ee/packages/omnichannel-services/.eslintrc.json
  • ee/packages/omnichannel-services/package.json
  • ee/packages/pdf-worker/.eslintrc.json
  • ee/packages/pdf-worker/package.json
  • ee/packages/presence/.eslintrc.json
  • ee/packages/presence/package.json
  • ee/packages/ui-theming/.eslintrc.json
  • ee/packages/ui-theming/package.json
  • eslint.config.mjs
  • package.json
  • packages/account-utils/.eslintrc.json
  • packages/account-utils/package.json
  • packages/agenda/.eslintrc.json
  • packages/agenda/package.json
  • packages/api-client/.eslintrc.json
  • packages/api-client/package.json
  • packages/apps-engine/.eslintrc.json
  • packages/apps-engine/package.json
  • packages/apps/.eslintrc.json
  • packages/apps/package.json
  • packages/base64/.eslintrc.json
  • packages/base64/package.json
  • packages/cas-validate/.eslintrc.json
  • packages/cas-validate/package.json
  • packages/core-services/.eslintrc.json
  • packages/core-services/package.json
  • packages/core-typings/.eslintrc.json
  • packages/core-typings/package.json
  • packages/core-typings/src/utils.ts
  • packages/cron/.eslintrc.json
  • packages/cron/package.json
  • packages/ddp-client/.eslintrc.json
  • packages/ddp-client/package.json
  • packages/desktop-api/.eslintrc.json
  • packages/desktop-api/package.json
  • packages/eslint-config/.eslintrc.json
  • packages/eslint-config/best-practices/index.js
  • packages/eslint-config/errors/index.js
  • packages/eslint-config/es6/index.js
  • packages/eslint-config/imports/index.js
  • packages/eslint-config/index.js
  • packages/eslint-config/node/index.js
  • packages/eslint-config/original/index.js
  • packages/eslint-config/package.json
  • packages/eslint-config/react.js
  • packages/eslint-config/standard/index.js
  • packages/eslint-config/style/index.js
  • packages/eslint-config/variables/index.js
  • packages/favicon/.eslintrc.json
  • packages/favicon/package.json
  • packages/fuselage-ui-kit/.eslintrc.json
  • packages/fuselage-ui-kit/package.json
  • packages/gazzodown/.eslintrc.json
  • packages/gazzodown/package.json
  • packages/http-router/.eslintrc.json
  • packages/http-router/package.json
  • packages/i18n/.eslintrc.json
  • packages/i18n/package.json
  • packages/instance-status/.eslintrc.json
  • packages/instance-status/package.json
  • packages/jest-presets/.eslintrc.json
  • packages/jest-presets/package.json
  • packages/jwt/.eslintrc.json
  • packages/jwt/package.json
  • packages/livechat/.eslintrc.json
  • packages/livechat/package.json
  • packages/log-format/.eslintrc.json
  • packages/log-format/package.json
  • packages/logger/.eslintrc.json
  • packages/logger/package.json
  • packages/media-signaling/.eslintrc.json
  • packages/media-signaling/package.json
  • packages/message-parser/.eslintrc.json
  • packages/message-parser/package.json
  • packages/message-types/.eslintrc.json
  • packages/message-types/package.json
  • packages/mock-providers/.eslintrc.json
  • packages/mock-providers/package.json
  • packages/model-typings/.eslintrc.json
  • packages/model-typings/package.json
  • packages/models/.eslintrc.json
  • packages/models/package.json
  • packages/mongo-adapter/.eslintrc.json
  • packages/mongo-adapter/package.json
  • packages/node-poplib/package.json
  • packages/omni-core/.eslintrc.json
  • packages/omni-core/package.json
  • packages/password-policies/.eslintrc.json
  • packages/password-policies/package.json
  • packages/patch-injection/.eslintrc.json
  • packages/patch-injection/package.json
  • packages/peggy-loader/.eslintrc.json
  • packages/peggy-loader/package.json
  • packages/random/.eslintrc.json
  • packages/random/package.json
  • packages/release-action/.eslintrc.json
  • packages/release-action/package.json
  • packages/release-changelog/.eslintrc.json
  • packages/release-changelog/package.json
  • packages/rest-typings/.eslintrc.json
  • packages/rest-typings/package.json
  • packages/server-cloud-communication/.eslintrc.json
  • packages/server-cloud-communication/package.json
  • packages/server-fetch/.eslintrc.json
  • packages/server-fetch/package.json
  • packages/sha256/.eslintrc.json
  • packages/sha256/package.json
  • packages/storybook-config/.eslintrc.json
  • packages/storybook-config/package.json
  • packages/tools/.eslintrc.json
  • packages/tools/package.json
  • packages/tracing/.eslintrc.json
  • packages/tracing/package.json
  • packages/ui-avatar/.eslintrc.json
  • packages/ui-avatar/package.json
  • packages/ui-client/.eslintrc.json
  • packages/ui-client/package.json
  • packages/ui-composer/.eslintrc.json
  • packages/ui-composer/package.json
  • packages/ui-contexts/.eslintrc.json
  • packages/ui-contexts/package.json
  • packages/ui-kit/.eslintrc.json
  • packages/ui-kit/package.json
  • packages/ui-video-conf/.eslintrc.json
  • packages/ui-video-conf/package.json
  • packages/ui-voip/.eslintrc.json
  • packages/ui-voip/package.json
  • packages/web-ui-registration/.eslintrc.json
  • packages/web-ui-registration/package.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tassoevan
Copy link
Copy Markdown
Member Author

tassoevan commented Feb 24, 2026

/jira ARCH-1935

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.70%. Comparing base (b4b9303) to head (c7c7b8a).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #38989      +/-   ##
===========================================
- Coverage    70.73%   70.70%   -0.03%     
===========================================
  Files         3195     3195              
  Lines       113095   113095              
  Branches     20514    20500      -14     
===========================================
- Hits         79994    79966      -28     
- Misses       31058    31087      +29     
+ Partials      2043     2042       -1
Flag Coverage Δ
e2e 60.35% <ø> (-0.05%) ⬇️
e2e-api 47.77% <ø> (-0.03%) ⬇️
unit 71.37% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo self-assigned this Feb 24, 2026
@ggazzo ggazzo added this to the 8.3.0 milestone Feb 24, 2026
@tassoevan tassoevan force-pushed the chore/eslint-upgrade branch 11 times, most recently from 4e9002b to b08ec70 Compare February 26, 2026 12:02
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2026
@KevLehman KevLehman added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Feb 26, 2026
@dionisio-bot dionisio-bot bot removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Feb 26, 2026
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Feb 26, 2026
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 26, 2026
@dionisio-bot dionisio-bot bot added this pull request to the merge queue Feb 26, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2026
@tassoevan tassoevan added this pull request to the merge queue Feb 26, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2026
@tassoevan tassoevan added this pull request to the merge queue Feb 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2026
@tassoevan tassoevan added this pull request to the merge queue Feb 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2026
@dionisio-bot dionisio-bot bot enabled auto-merge February 27, 2026 02:51
@dionisio-bot dionisio-bot bot added this pull request to the merge queue Feb 27, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2026
@KevLehman KevLehman added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels Feb 27, 2026
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 27, 2026
@dionisio-bot dionisio-bot bot added this pull request to the merge queue Feb 27, 2026
@ggazzo ggazzo removed this pull request from the merge queue due to a manual request Feb 27, 2026
@ggazzo ggazzo merged commit 539659a into develop Feb 27, 2026
49 checks passed
@ggazzo ggazzo deleted the chore/eslint-upgrade branch February 27, 2026 14:16
@tassoevan tassoevan mentioned this pull request Feb 27, 2026
Merged
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Mar 3, 2026
Closed
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Mar 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@ggazzo ggazzo ggazzo approved these changes

@KevLehman KevLehman KevLehman approved these changes

Assignees

@ggazzo ggazzo

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

8.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tassoevan @ggazzo @KevLehman