Skip to content

fix: MarkdownText variant document ignoring \n#38983

Merged
ggazzo merged 3 commits intodevelopfrom
copilot/fix-webhook-for-new-line
Feb 24, 2026
Merged

fix: MarkdownText variant document ignoring \n#38983
ggazzo merged 3 commits intodevelopfrom
copilot/fix-webhook-for-new-line

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 24, 2026

  • Fix literal \n in webhook messages not being converted to actual newlines in processWebhookMessage.ts
  • Add unit test for escapeSequencesToNewlines in processWebhookMessage.spec.ts
  • Register spec pattern in .mocharc.js
  • Code review feedback incorporated (combined regex replacements)
  • CodeQL security check passed
  • Add changeset for @rocket.chat/meteor patch

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Task: ARCH-2072

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Feb 24, 2026

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 24, 2026

🦋 Changeset detected

Latest commit: d7b69b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/abac Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/server-fetch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI changed the title [WIP] Fix webhook not working for new line in RC 3.12.1 fix: convert literal \n escape sequences to newlines in webhook messages Feb 24, 2026
Copilot AI requested a review from ggazzo February 24, 2026 13:19
@ggazzo ggazzo force-pushed the copilot/fix-webhook-for-new-line branch from 3d3b405 to d0d6721 Compare February 24, 2026 13:50
@ggazzo ggazzo changed the title fix: convert literal \n escape sequences to newlines in webhook messages fix: MarkdownText variant document ignoring \n Feb 24, 2026
@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Feb 24, 2026

@copilot add changeset

@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Feb 24, 2026

/jira ARCH-1935

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 24, 2026

@copilot add changeset

Added in d7b69b6.changeset/fix-webhook-newline.md marks @rocket.chat/meteor as a patch.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Feb 24, 2026
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 24, 2026
@ggazzo ggazzo marked this pull request as ready for review February 24, 2026 14:20
@ggazzo ggazzo requested a review from a team as a code owner February 24, 2026 14:20
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.66%. Comparing base (3048477) to head (d7b69b6).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #38983      +/-   ##
===========================================
+ Coverage    70.64%   70.66%   +0.02%     
===========================================
  Files         3189     3189              
  Lines       112715   112716       +1     
  Branches     20363    20439      +76     
===========================================
+ Hits         79627    79653      +26     
+ Misses       31044    31020      -24     
+ Partials      2044     2043       -1     
Flag Coverage Δ
unit 71.22% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@ggazzo ggazzo merged commit 55bf071 into develop Feb 24, 2026
26 of 27 checks passed
@ggazzo ggazzo deleted the copilot/fix-webhook-for-new-line branch February 24, 2026 14:32
@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Mar 20, 2026

/jira ARCH-2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants