Reviewing files that changed from the base of the PR and between 508b4a1 and a67ed32.

• apps/meteor/app/integrations/server/lib/triggerHandler.ts

• GitHub Check: cubic · AI code reviewer

apps/meteor/app/integrations/server/lib/triggerHandler.ts (1)

615-623: The size option is properly supported. The @rocket.chat/server-fetch package explicitly uses node-fetch v2.7.0, and the ExtendedFetchOptions type includes size?: number which is passed through to the underlying fetch call via parseRequestOptions. The fix will work as intended.

However, the generic error handler at line 786 doesn't distinguish a size limit exceeded error from other network errors. Consider adding explicit handling for the max-size error type to provide better observability:

.catch(async (err) => {
+  if (err?.type === 'max-size') {
+    outgoingLogger.warn({ msg: 'Integration response exceeded size limit', integrationName: trigger.name, url });
+  } else {
     outgoingLogger.error({ err });
+  }
   await updateHistory({
     historyId,
     step: 'after-http-call',
     httpError: err,
     httpResult: null,
   });
 });

Additionally, consider extracting the magic number 20 * 1024 * 1024 to a named constant for clarity and maintainability.

Reviewing files that changed from the base of the PR and between 35e0290 and 3108c1d.

• .changeset/shiny-pears-admire.md
• apps/meteor/app/integrations/server/lib/triggerHandler.ts

• apps/meteor/app/integrations/server/lib/triggerHandler.ts

.changeset/shiny-pears-admire.md (2)

7-7: Error handling exists for the FetchError from the size limit.

The fetch call at line 615-627 is properly wrapped with a .catch() block (lines 788-796) that handles any errors thrown by node-fetch, including the FetchError with type: 'max-size' when the 10MB size limit is exceeded. The error is logged via outgoingLogger.error() and recorded in the integration history, preventing an unhandled rejection.

Likely an incorrect or invalid review comment.

---

7-7: The size option is properly supported. triggerHandler.ts uses @rocket.chat/server-fetch, which wraps node-fetch 2.7.0—not the Node.js global fetch (undici). The node-fetch library fully supports the size option for limiting response body size. The option is defined in ExtendedFetchOptions, passed through parseRequestOptions() without filtering, and spreads into the underlying fetch() call. The 10MB size limit in the changeset is effectively enforced.

Likely an incorrect or invalid review comment.