Skip to content

fix(i18n): use correct i18n key for workspace confirmation#38662

Merged
ggazzo merged 5 commits intoRocketChat:developfrom
TheRazorbill:fix/register-workspace-confirmation-i18n
Feb 26, 2026
Merged

fix(i18n): use correct i18n key for workspace confirmation#38662
ggazzo merged 5 commits intoRocketChat:developfrom
TheRazorbill:fix/register-workspace-confirmation-i18n

Conversation

@TheRazorbill
Copy link
Copy Markdown
Contributor

@TheRazorbill TheRazorbill commented Feb 13, 2026 •
edited by atlassian bot
Loading

Proposed changes (including videos or screenshots)

  • Fix wrong i18n key in RegisterWorkspace confirmation step so the text is translated instead of showing a missing key.

Issue(s)

Closes: #38830
COMM-144

Steps to test or reproduce

  1. Go to workspace registration flow (step 2).
  2. Observe the confirmation email text is shown (translated), not a missing i18n key.

Further comments

  • N/A

Before/After

image

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a translation key in the Register Workspace email confirmation step so the correct localized text now displays during workspace registration.
    • Ensures users no longer see a missing translation key in the confirmation UI, improving clarity for non-English locales.

@TheRazorbill TheRazorbill requested a review from a team as a code owner February 13, 2026 18:12
Copilot AI review requested due to automatic review settings February 13, 2026 18:12
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Feb 13, 2026 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 13, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 049ca21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 41 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/http-router Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/abac Patch
@rocket.chat/federation-matrix Patch
@rocket.chat/license Patch
@rocket.chat/media-calls Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/network-broker Patch
@rocket.chat/omni-core-ee Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/instance-status Patch
@rocket.chat/omni-core Patch
@rocket.chat/server-fetch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 13, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd5a113 and 049ca21.

📒 Files selected for processing (1)
  • .changeset/fix-register-workspace-i18n.md

Walkthrough

Corrects an i18n key used in the workspace registration confirmation step: replaces RegisterWorkspace_Setup_Email_Confirmation with cloud.RegisterWorkspace_Setup_Email_Confirmation. Adds a changeset documenting the patch.

Changes

Cohort / File(s) Summary
I18n Key Update
apps/meteor/client/views/admin/workspace/VersionCard/modals/RegisterWorkspaceSetupModal/RegisterWorkspaceSetupStepTwoModal.tsx		 Replaced Trans i18nKey RegisterWorkspace_Setup_Email_Confirmation → cloud.RegisterWorkspace_Setup_Email_Confirmation.
Changeset Entry
.changeset/fix-register-workspace-i18n.md		 Added patch-level changeset documenting the i18n key fix for the RegisterWorkspace confirmation step.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing the i18n key for workspace confirmation in the RegisterWorkspace flow.
Linked Issues check ✅ Passed The PR successfully addresses issue #38830 by changing the i18nKey from RegisterWorkspace_Setup_Email_Confirmation to cloud.RegisterWorkspace_Setup_Email_Confirmation as proposed.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the i18n key issue in the workspace registration confirmation step; no out-of-scope changes detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI reviewed Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the workspace registration step-2 confirmation text to use the correct i18n key so the UI shows a translated string instead of a missing-translation key.

Changes:

  • Switch Trans i18n key from RegisterWorkspace_Setup_Email_Confirmation to cloud.RegisterWorkspace_Setup_Email_Confirmation.
Comments suppressed due to low confidence (1)

apps/meteor/client/views/admin/workspace/VersionCard/modals/RegisterWorkspaceSetupModal/RegisterWorkspaceSetupStepTwoModal.tsx:90

  • With this key change, Trans will start using the existing translation string cloud.RegisterWorkspace_Setup_Email_Confirmation, which currently contains literal <1>email</1> in the locale files. That means the rendered UI will show the word “email” instead of the actual email prop value. To keep the dynamic email address, update the translation to use interpolation (e.g., <1>{{emailAddress}}</1>) and pass values to Trans (e.g., { emailAddress: email }).
						<Trans i18nKey='cloud.RegisterWorkspace_Setup_Email_Confirmation'>
							<Box is='p'>
								Email sent to{' '}
								<Box is='span' fontScale='p2b'>
									{email}{' '}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Feb 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@TheRazorbill
Copy link
Copy Markdown
Contributor Author

TheRazorbill commented Feb 13, 2026

Lint: yarn lint --filter @rocket.chat/meteor (179 warnings preexisting, no errors)

@TheRazorbill TheRazorbill mentioned this pull request Feb 20, 2026
Closed
@TheRazorbill TheRazorbill force-pushed the fix/register-workspace-confirmation-i18n branch from 4159aeb to b987eb8 Compare February 20, 2026 00:19
@TheRazorbill TheRazorbill requested review from a team as code owners February 20, 2026 00:19
@coderabbitai coderabbitai bot added stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge labels Feb 20, 2026
@dionisio-bot dionisio-bot bot added stat: conflict and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 20, 2026
@TheRazorbill TheRazorbill force-pushed the fix/register-workspace-confirmation-i18n branch from b987eb8 to dd5a113 Compare February 20, 2026 00:25
@KevLehman KevLehman added the valid A valid contribution where maintainers will review based on priority label Feb 20, 2026
@TheRazorbill
Copy link
Copy Markdown
Contributor Author

TheRazorbill commented Feb 26, 2026

Hi team! 👋

I've resolved the conflicts and the previous feedback. Could someone from @RocketChat/frontend please review this?

@ggazzo ggazzo added this to the 8.3.0 milestone Feb 26, 2026
@ggazzo ggazzo changed the title fix: use correct i18n key for workspace confirmation fix(i18n): use correct i18n key for workspace confirmation Feb 26, 2026
@ggazzo ggazzo merged commit afaabea into RocketChat:develop Feb 26, 2026
6 of 7 checks passed
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Mar 3, 2026
Closed
@rocketchat-github-ci rocketchat-github-ci mentioned this pull request Mar 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

community stat: QA assured Means it has been tested and approved by a company insider type: bug valid A valid contribution where maintainers will review based on priority

Projects

None yet

Milestone

8.3.0

Development

Successfully merging this pull request may close these issues.

i18n: Fix missing translation in Workspace Registration flow

5 participants

@TheRazorbill @ggazzo @KevLehman @AliNunes