Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

⚠️ No Changeset found

Latest commit: 3707a37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Walkthrough

Removes the federation-specific branch from addUsersToRoom and unregisters the related callback. Updates type signatures accordingly. Extends role methods’ room projections to include federation. Bumps @rocket.chat/federation-sdk to 0.1.13. Refactors federation-matrix invite/join flows, adds acceptInvite, introduces getUsernameServername, and threads HomeserverServices through event handlers.

Changes

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Client
  participant MeteorServer as Server Method addUsersToRoom
  participant UserService as User/Subscriptions
  participant Notifier

  Client->>MeteorServer: addUsersToRoom({ rid, users })
  Note over MeteorServer: Federated branch removed
  loop for each username
    MeteorServer->>UserService: find user by username
    alt user already member
      MeteorServer->>Notifier: notify already in room
    else user not member
      MeteorServer->>UserService: add user to room
      MeteorServer->>Notifier: notify user added
    end
  end
  MeteorServer-->>Client: boolean result

sequenceDiagram
  autonumber
  participant App as FederationMatrix
  participant Homeserver as HomeserverServices
  participant Accept as acceptInvite

  App->>Homeserver: inviteUserToRoom(roomId, username)
  Homeserver-->>App: invite sent/ack
  App->>Accept: acceptInvite(inviteEvent, username, services)
  Accept->>Homeserver: validate invite and join room (with backoff)
  Homeserver-->>Accept: joined
  Accept-->>App: done

sequenceDiagram
  autonumber
  participant HS as Homeserver (Matrix)
  participant Events as registerEvents
  participant Member as member()
  participant Users as createOrUpdateFederatedUser
  participant Rooms as Room/Subscriptions

  HS-->>Events: m.room.member (join)
  Events->>Member: membershipJoinAction(data, services)
  Member->>Member: getUsernameServername(state_key, serverName)
  alt user is local
    Member->>Rooms: check existing subscription
    alt subscription exists
      Member-->>Events: skip add
    else
      Users->>Users: createOrUpdateFederatedUser({ username, origin, name })
      Member->>Rooms: add user to room
    end
  else federated user
    Users->>Users: createOrUpdateFederatedUser({ username (mxid), origin, name })
    Member->>Rooms: add user to room
  end

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• chore: remove old federation #37059 — Removes legacy federation hooks/paths, aligning with this PR’s deletion of federation.onAddUsersToRoom and method simplification.
• fix: fixes reviews of chore/federation-backup #37016 — Adjusts federation invite handling around add-users flow and hooks; closely matches the refactors to inviteUsersToRoom.
• chore: bring improvements from federation branch #36968 — Changes the add users to room federation flow and related callbacks, overlapping with the hook removal and method updates here.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

• ricardogarim
• sampaiodiego

Poem

Hoppity-hop, I tweak the loom,
Threads of rooms now weave one loom.
Callbacks trimmed, invites aligned,
Homeservers whisper, well-designed.
With gentle paws, I merge the way—
Matrix doors open, come what may. 🐇✨

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}