feat: adds Federation GET /events/{eventId} endpoint by ricardogarim · Pull Request #36873 · RocketChat/Rocket.Chat

ricardogarim · 2025-09-04T22:07:21Z

Previously tied to RocketChat/homeserver#161. We’ve decided to move forward by pushing only the route implementation, leaving out the ACL for now. This helps us isolate domain concerns and speed up the overall work.

Response example for GET /_matrix/federation/v1/event/$KMoGnWYWjaoKlZ0FrmYJjWcc8LGLGz-JoOuvM14gqKU

{
  "origin_server_ts": 1757538253737,
  "origin": "rc1",
  "pdus": [
    {
      "auth_events": [
        "$f9msK-kfJrGKleYgsqpLqSP-MchU4-7I_RIdIIA2J5Y",
        "$SWbOYtZ_1fdwE5V8rKQxx76oQgCEz_YnIfvIYDlwt-g",
        "$yWP9I1nqioBqgdeD6-lxPqh1j2qoUYf5Sxw7qY6syeI"
      ],
      "prev_events": [
        "$io6obrsV6Gnc9czkyEamVejsDWvUOEvRFHIhomai0KM"
      ],
      "type": "m.reaction",
      "room_id": "!CawYSGPh:rc1",
      "sender": "@admin:hs1",
      "content": {
        "m.relates_to": {
          "rel_type": "m.annotation",
          "event_id": "$1Na9fJixdb5fm6tr8moV1OIogFQyPKwJP19ZDIi0BIE",
          "key": "😍"
        }
      },
      "depth": 2,
      "origin": "hs1",
      "origin_server_ts": 1753919202258,
      "hashes": {
        "sha256": "LRr1OOmNP7K6w28uUtyeNhpa2uZSPE40G2WlszdElvo"
      },
      "signatures": {
        "hs1": {
          "ed25519:a_HDhg": "aKVRZDFfHmNY6Q1wvXKJ6pFpKr7BB/jwEs6dXyEpLIQrb+YZElD45Y66oqlw5H5mTfVLIlkxE9pgkhQG/dH8BA"
        }
      },
      "unsigned": {
        "age": 6848
      }
    }
  ]
}

dionisio-bot · 2025-09-04T22:07:25Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2025-09-04T22:07:26Z

⚠️ No Changeset found

Latest commit: b342b58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-09-10T20:50:00Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feat/federation-get-eventid

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-09-10T21:08:04Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.59%. Comparing base (a5c5e9e) to head (b342b58).
⚠️ Report is 2 commits behind head on feat/federation.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           feat/federation   #36873      +/-   ##
===================================================
- Coverage            69.60%   69.59%   -0.02%     
===================================================
  Files                 3011     3010       -1     
  Lines                99946    99888      -58     
  Branches             18417    18413       -4     
===================================================
- Hits                 69568    69513      -55     
+ Misses               28402    28400       -2     
+ Partials              1976     1975       -1

Flag	Coverage Δ
e2e	`57.64% <ø> (-0.03%)`	⬇️
unit	`71.62% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ricardogarim marked this pull request as draft September 4, 2025 22:07

ricardogarim mentioned this pull request Sep 4, 2025

feat: adds event ACL RocketChat/homeserver#161

Merged

feat: adds get eventId and acl middleware

b120ccf

ricardogarim force-pushed the feat/federation-get-eventid branch from f8d4acf to b120ccf Compare September 4, 2025 22:16

ricardogarim added 2 commits September 4, 2025 20:01

makes return right props on get event route

045d8dd

removes ACL to isolate into a proper PR

2acbdad

makes origin_server_ts as now

b342b58

ricardogarim marked this pull request as ready for review September 10, 2025 21:10

sampaiodiego approved these changes Sep 12, 2025

View reviewed changes

sampaiodiego merged commit a1f650f into feat/federation Sep 12, 2025
92 of 94 checks passed

sampaiodiego deleted the feat/federation-get-eventid branch September 12, 2025 17:55

ggazzo pushed a commit that referenced this pull request Sep 16, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

4a08e54

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

87edc69

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

146c687

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

4626413

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

b6fab6e

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

0e11e68

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

a468739

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

4376900

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

6282141

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

a4687db

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

63b7043

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

e720f79

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

b8de8fc

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

c7fadc3

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

061ae2a

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

937e705

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

d61b07f

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

a232e26

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

f609cae

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

fcb7be9

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

2a8158c

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

2b45a8b

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

19bbf83

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

252271e

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

15be570

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

d6d7535

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

184b305

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

d1a5219

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

9352725

ggazzo pushed a commit that referenced this pull request Sep 17, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

e8314fc

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

9b357fa

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

43ede7e

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

ef5bf95

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

ffdbc28

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

1827c5f

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

e9a25f1

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

58a6517

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

deaf917

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

5d3c338

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

0f56b41

ggazzo pushed a commit that referenced this pull request Sep 18, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

5f0a96f

ggazzo pushed a commit that referenced this pull request Sep 19, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

9dc26f8

ggazzo pushed a commit that referenced this pull request Sep 19, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

2464b46

ggazzo pushed a commit that referenced this pull request Sep 23, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

f424bc9

ggazzo pushed a commit that referenced this pull request Sep 25, 2025

feat: adds Federation GET /events/{eventId} endpoint (#36873)

f2f7cd2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adds Federation GET /events/{eventId} endpoint#36873

feat: adds Federation GET /events/{eventId} endpoint#36873
sampaiodiego merged 4 commits intofeat/federationfrom
feat/federation-get-eventid

ricardogarim commented Sep 4, 2025 •

edited

Loading

Uh oh!

dionisio-bot bot commented Sep 4, 2025

Uh oh!

changeset-bot bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 10, 2025 •

edited

Loading

Review skipped

Uh oh!

codecov bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ricardogarim commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dionisio-bot bot commented Sep 4, 2025

Uh oh!

changeset-bot bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

codecov bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ricardogarim commented Sep 4, 2025 •

edited

Loading

changeset-bot bot commented Sep 4, 2025 •

edited

Loading

coderabbitai bot commented Sep 10, 2025 •

edited

Loading

codecov bot commented Sep 10, 2025 •

edited

Loading