fix: multi paths is present inside the APIClass#36678
Closed
ahmed-n-abdeltwab wants to merge 1 commit intoRocketChat:developfrom
Closed
fix: multi paths is present inside the APIClass#36678ahmed-n-abdeltwab wants to merge 1 commit intoRocketChat:developfrom
ahmed-n-abdeltwab wants to merge 1 commit intoRocketChat:developfrom
Conversation
|
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Contributor
Author
|
i think we dont need this anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on the dm.delete API PR #36677, I discovered an issue where the endpoint definition used an array in the base path:
The current APIClass implementation expects a single path string, not an array. As a result, several parts of the codebase; such as ExtractRoutesFromAPI - were failing, causing unexpected behavior.