Skip to content

refactor: enhance API error response validation and accessibility#36574

Merged
kodiakhq[bot] merged 5 commits intoRocketChat:developfrom
ahmed-n-abdeltwab:refactor/openapi-error-schemas
Jul 31, 2025
Merged

refactor: enhance API error response validation and accessibility#36574
kodiakhq[bot] merged 5 commits intoRocketChat:developfrom
ahmed-n-abdeltwab:refactor/openapi-error-schemas

Conversation

@ahmed-n-abdeltwab
Copy link
Copy Markdown
Contributor

@ahmed-n-abdeltwab ahmed-n-abdeltwab commented Jul 30, 2025 •
edited by ggazzo
Loading

implement standardized validation for error responses across various API endpoints.
https://rocketchat.atlassian.net/browse/ARCH-1728

@ahmed-n-abdeltwab ahmed-n-abdeltwab requested review from a team as code owners July 30, 2025 16:19
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Jul 30, 2025 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 30, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4e8bfd8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.44%. Comparing base (0776b21) to head (cdeb8f0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36574      +/-   ##
===========================================
- Coverage    65.84%   64.44%   -1.40%     
===========================================
  Files         3188     2921     -267     
  Lines       106678   102563    -4115     
  Branches     20306    19349     -957     
===========================================
- Hits         70237    66101    -4136     
- Misses       33772    34090     +318     
+ Partials      2669     2372     -297
Flag Coverage Δ
e2e 52.07% <ø> (-6.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cardoso cardoso added this to the 7.10.0 milestone Jul 30, 2025
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 31, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 31, 2025
@kodiakhq kodiakhq bot merged commit 5f3ac3a into RocketChat:develop Jul 31, 2025
46 checks passed
This was referenced Jul 31, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

gsoc-project stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

7.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ahmed-n-abdeltwab @ggazzo @cardoso