Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 64f803b The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #34983 +/- ##
========================================
Coverage 59.65% 59.65%
========================================
Files 2828 2828
Lines 68528 68528
Branches 15188 15188
========================================
Hits 40879 40879
Misses 25001 25001
Partials 2648 2648
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
|
@kody start-review |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
it can be accessed by
docs/jsonUI can be accessed by
/api-docsARCH-1550
result : https://rocketchat.apidocumentation.com/reference#tag/missing-documentation/POST/api/v1/rooms.cleanHistory
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This pull request introduces a proof of concept for OpenAPI integration into the Rocket.Chat API. It focuses on enhancing type safety, documentation, and validation across various API components. Key changes include:
api.ts, allowing for OpenAPI-like documentation and validation.definition.tswith new TypeScript types for improved type safety and error handling.openApiimport inindex.ts, with noted potential for better code organization and documentation.openApi.ts.custom-sounds.tsAPI endpoint to include comprehensive response validation using AJV and improved type definitions.federation.tsAPI endpoints to use chained get methods, with added AJV schema validation for responses and enhanced type safety.invites.tsAPI route definitions to use chained methods and inclusion of response validation schemas using AJV for better organization.