One "problem" with this feature is that team owners will be able to create rooms inside teams, but there won't be any way for them to delete those rooms unless they have the global delete permission. Ideally anyone who can create a room should be able to also delete it afterwards.

But in this case we can't simply add a delete-team-channel permission either, because team owners would then be able to delete any global room by simply adding it to their team first.

I don't know what the ideal solution is, but I believe it's just a matter of time until we get people requesting a delete-team-channel permission after this one is merged.

@pierre-lehnen-rc with the PR as it is right now, users who have the new permission to add channels/groups would only be able to delete the channels they own (since we check the delete-c and delete-p permissions in the deleted room scope).

I thought of two ways these two new delete-team-channel / delete-team-group permissions could behave if we introduce them:

• They could "override" the global permissions, so that anyone that has this permission in a team would be able to delete ANY room in it (even the ones they don't own);
• They could complement the permission to delete a room. So a user would only be able to delete a room that is part of a team if they own it (delete-c/delete-p permissions, which are currently checked within the deleted room's scope) and are also allowed to delete it in the team.

I'll check what's the behavior we'd like to have in the product. Maybe we should also make this clear somewhere if we decide to implement it.