Merged
Conversation
Generalized the FreePaidDropDownList into a component called RadioButtonList, started the implementation of the visual part of the marketplace sort filter component, created new sub folders for the Components folder of the Apps view and generalized the FreePaidDropDownPDefinitions type definition into a new type caled RadioDropDownDefinitions.
ujorgeleite
force-pushed
the
feat-market-sort-filters
branch
from
fed8d74 to
06c3b73
Compare
geekgonecrazy
approved these changes
Feb 22, 2022
Contributor
geekgonecrazy
left a comment
geekgonecrazy
left a comment
There was a problem hiding this comment.
From my perspective this looks good
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Implemented a sort filter for the marketplace screen. This component sorts the marketplace apps list in 4 ways, alphabetical order(A-Z), inverse alphabetical order(Z-A), most recently updated(MRU), and least recent updated(LRU). Besides that, I've generalized some components and types to increase code reusability, renamed some helpers as well as deleted some useless ones, and inserted the necessary new translations on the English i18n dictionary.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments