[FIX] Skip admin info in setup wizard for servers with admin registered#24485
Merged
dougfabris merged 4 commits intodevelopfrom Feb 18, 2022
Merged
[FIX] Skip admin info in setup wizard for servers with admin registered#24485dougfabris merged 4 commits intodevelopfrom
dougfabris merged 4 commits intodevelopfrom
Conversation
gabriellsh
previously requested changes
Feb 15, 2022
Member
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
As in our previous conversation, the flag for if there's an admin already should come from the server. Current behaviour in this PR doesn't account for if the admin is logged out.
Also, only logged admins should be able to view the setup wizard, which isn't the current case.
tassoevan
force-pushed
the
fix/skip-admin
branch
from
67c97fa to
a036754
Compare
tassoevan
approved these changes
Feb 18, 2022
dougfabris
dismissed
gabriellsh’s stale review
We're going to cover the case reported which is an older issue in another PR
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments