[FIX] Create findOneByRolesAndType function#24308
Merged
matheusbsilva137 merged 3 commits intofix/24148-respect-default-role-settingfrom Feb 10, 2022
Merged
[FIX] Create findOneByRolesAndType function#24308matheusbsilva137 merged 3 commits intofix/24148-respect-default-role-settingfrom
findOneByRolesAndType function#24308matheusbsilva137 merged 3 commits intofix/24148-respect-default-role-settingfrom
Conversation
matheusbsilva137
changed the title
findOneByRolesAndType functionfindOneByRolesAndType function
matheusbsilva137
added a commit
that referenced
this pull request
Feb 18, 2022
…4173) * Fix role handling if setup wizard pending and no admin found Signed-off-by: Debdut Chakraborty <[email protected]> * [FIX] Create `findOneByRolesAndType` function (#24308) * Create findOneByRolesAndType function and stop adding user role by default * Remove logs * Remove default user role in userHandler.js * Update app/authentication/server/startup/index.js Co-authored-by: Debdut Chakraborty <[email protected]> * fix lint issues * Check if the server has an admin user before assigning the admin role on server startup Co-authored-by: Matheus Barbosa Silva <[email protected]> Co-authored-by: matheusbsilva137 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments