Skip to content

[FIX] Prevent Apps Bridge to remove visitor status from room#24305

Merged
d-gubert merged 3 commits intodevelopfrom
fix/apps-bridge-ignore-visitor-status
Feb 9, 2022
Merged

[FIX] Prevent Apps Bridge to remove visitor status from room#24305
d-gubert merged 3 commits intodevelopfrom
fix/apps-bridge-ignore-visitor-status

Conversation

@KevLehman
Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Copy Markdown
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing through the tests! 😃
Waiting on @d-gubert review... 🙈

@d-gubert
Copy link
Copy Markdown
Member

@KevLehman the status property is already accepted in the apps-engine side?

@KevLehman
Copy link
Copy Markdown
Member Author

(I hope I understood the question 😬, but will try)

Yep, they can use the status prop, and they can pass it as a param. What was happening is that, some apps trigger a "room update" after doing some initial modifications (like, setting custom fields). The app at that point can update the full room object, even if the update was just a key 👀 . But, the problem was that apps-engine was returning a "smaller" room.v prop with just _id, username, token even if the status was already set (by the default values on omnichannel side).

@d-gubert d-gubert merged commit e7bc102 into develop Feb 9, 2022
@d-gubert d-gubert deleted the fix/apps-bridge-ignore-visitor-status branch February 9, 2022 18:22
@pierre-lehnen-rc pierre-lehnen-rc mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants