Chore: Slash Commands Join to Typescript#24254
Merged
Conversation
|
|
|
This pull request introduces 2 alerts when merging b0c6962 into 3e14178 - view on LGTM.com new alerts:
|
ostjen
suggested changes
Jan 24, 2022
Contributor
ostjen
left a comment
ostjen
left a comment
There was a problem hiding this comment.
there's also 3 new unwanted files that you should delete
|
|
||
| import { slashCommands } from '../../utils/lib/slashCommand'; | ||
|
|
||
| console.log('T'); |
|
This pull request introduces 2 alerts when merging df97b2b into 7cfd4b0 - view on LGTM.com new alerts:
|
ostjen
suggested changes
Jan 24, 2022
| params.msg.msg = params.msg.msg.replace('join', 'open'); | ||
| return slashCommands.run('open', params.params, params.msg); | ||
| } | ||
| result = result; |
ostjen
reviewed
Jan 25, 2022
Comment on lines
+150
to
+153
| undefined, | ||
| false, | ||
| undefined, | ||
| undefined, |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Convert the slash commands .js files to .ts files.
Issue(s)
Steps to test or reproduce
Further comments