Skip to content

[IMPROVE] lib/Statistics improved and metrics collector#24177

Merged
albuquerquefabio merged 26 commits intodevelopfrom
improve/statistics
Jan 24, 2022
Merged

[IMPROVE] lib/Statistics improved and metrics collector#24177
albuquerquefabio merged 26 commits intodevelopfrom
improve/statistics

Conversation

@albuquerquefabio
Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

  • On statistics object the property get is an async function now.
  • We need to collect additional data of feature activation through the statistics collector.
    • Some codes were splitted into another file just to organize.

Issue(s)

Steps to test or reproduce

Further comments

@albuquerquefabio albuquerquefabio added area: backend Touches the code on backend side feat: statistics labels Jan 14, 2022
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 14, 2022

This pull request introduces 1 alert when merging 338f3bb into f37c2f4 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 18, 2022

This pull request introduces 1 alert when merging 42306ad into fb98052 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 18, 2022

This pull request introduces 1 alert when merging afe6c57 into 6e16ba8 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 21, 2022

This pull request introduces 1 alert when merging 553dd55 into fbe10e7 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 21, 2022

This pull request introduces 1 alert when merging 5c2d14d into fbe10e7 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@tassoevan
Copy link
Copy Markdown
Member

  • 1 for Syntax error

I think there are some calls of Promise.await to be replaced with await.

@albuquerquefabio albuquerquefabio merged commit 328fbeb into develop Jan 24, 2022
@albuquerquefabio albuquerquefabio deleted the improve/statistics branch January 24, 2022 20:58
gabriellsh added a commit that referenced this pull request Jan 25, 2022
…age-template-2

* 'develop' of github.com:RocketChat/Rocket.Chat: (81 commits)
  Language update from LingoHub 🤖 (#24268)
  Regression: Fix incompatibility of apps http requests (#24276)
  [IMPROVE] lib/Statistics improved and metrics collector (#24177)
  [FIX] Fixing the changing custom status behavior (#24218)
  Regression: Align Omni-Source icon sizes with designs (#24269)
  Regression: Fix Inactive Departments still visible on Livechat (#24267)
  [FIX] Solved Report Message Blank (#24262)
  [FIX] Errors on advanced sync prevent LDAP users from logging in (#23958)
  Chore: Convert model LoginServiceConfiguration to raw (#24187)
  [FIX] Make canned responses popup dependent on Canned_responses_enabled setting (#23804)
  [FIX] Wrong german translation for 2FA-Promt (#24126)
  Bump follow-redirects from 1.14.5 to 1.14.7 in /ee/server/services (#24182)
  Chore: Update pino and pino-pretty (#24242)
  [FIX] Avoid updating all rooms with visitor abandonment queries (#24252)
  Add: Alpine image as option for build (#12548)
  Fixed broken links in setup wizard (#24248)
  [FIX] Apps Contextual Bar not carrying title and room information   (#24241)
  Chore: Bump fuselage hooks (#24233)
  Regression: Remove extra call to `useOutsideClick` hook not following the function signature (#24243)
  [FIX] Change canned response model index to match other definition (#24235)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: backend Touches the code on backend side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants