[FIX] Not importing users from csv file#24073
Closed
kulkarnigaurav38 wants to merge 2 commits intoRocketChat:developfrom
Closed
[FIX] Not importing users from csv file#24073kulkarnigaurav38 wants to merge 2 commits intoRocketChat:developfrom
kulkarnigaurav38 wants to merge 2 commits intoRocketChat:developfrom
Conversation
tassoevan
requested changes
Dec 31, 2021
| 0() { | ||
| return !Meteor.userId() || !hasPermission(Meteor.userId(), 'edit-other-user-info'); | ||
| }, // Administrators have permission to change others names, so don't limit those | ||
| 0() { return !Meteor.userId || !hasPermission(Meteor.userId, 'edit-other-user-info'); }, // Administrators have permission to change others names, so don't limit those |
Member
There was a problem hiding this comment.
This doesn't look right. Meteor.userId is a function, therefore !Meteor.userId is always false. The first parameter of hasPermission(userId, permissionId, scope) is supposed to be the value returned by calling Meteor.userId().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The users.csv file was being read properly, but the importing process throws an error when trying to import users details. Further details are mentioned in the issue.
Proposed changes (including videos or screenshots)
Rocket.Chat.-.Google.Chrome.2021-12-31.12-58-26.mp4
Issue(s)
#23997Steps to test or reproduce
Further comments
Error which showed up earlier in the logs is solved now
