[FIX] Custom emoji route in admin#23882
Merged
dougfabris merged 4 commits intoRocketChat:developfrom Dec 14, 2021
Merged
Conversation
dougfabris
previously approved these changes
Dec 11, 2021
dougfabris
approved these changes
Dec 14, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23858
As there were two "CustomEmoji" files, the .js file was given more priority but intended purpose was to import the newly created tsx file. I tried to dig into it and found out this code-tsc, maybe this sets priority in way that .js > .tsx. So, almost everything that is received from props are coming out to be undefined. Hence, we get that error. By removing the js file, the problem gets resolved.
Proposed changes (including videos or screenshots)
fix-custom-emoji.mp4
Issue(s)
Closes #23858
Further comments
Also, I think it makes more sense to add the "delete" button only on the edit custom emoji part and not while adding a custom emoji.