Skip to content

Chore: PoC prettier#23792

Closed
KevLehman wants to merge 4 commits intodevelopfrom
chore/poc-prettier
Closed

Chore: PoC prettier#23792
KevLehman wants to merge 4 commits intodevelopfrom
chore/poc-prettier

Conversation

@KevLehman
Copy link
Copy Markdown
Member

@KevLehman KevLehman commented Nov 25, 2021

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 25, 2021

This pull request fixes 7 alerts when merging 159548b into 9ce2291 - view on LGTM.com

fixed alerts:

  • 7 for Useless regular-expression character escape

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Nov 26, 2021

This pull request fixes 7 alerts when merging 164b422 into 8a9f5d0 - view on LGTM.com

fixed alerts:

  • 7 for Useless regular-expression character escape

@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Nov 26, 2021

❤️

my little secret:
image
I have been using for a while, I'm 100% with you

sampaiodiego
sampaiodiego requested changes Dec 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried using the client's prettier config? https://github.com/RocketChat/Rocket.Chat/blob/develop/client/.prettierrc

or maybe another question, should we use the same config for the entire repo?

@KevLehman
Copy link
Copy Markdown
Member Author

KevLehman commented Dec 16, 2021

I have been using for a while, I'm 100% with you

I knew your formatting was too perfect <3

or maybe another question, should we use the same config for the entire repo?

Well that's a good question. I don't know 😬 should we? Would be good to have an "standard" style for the whole codebase, but, FE & BE may have different needs (?) (not sure tho)

@sampaiodiego
Copy link
Copy Markdown
Member

sampaiodiego commented Dec 16, 2021

I think it works if we have a .prettierrc on root and others with specific rules in different folders.. maybe you can try that? 😬

@KevLehman
Copy link
Copy Markdown
Member Author

KevLehman commented Dec 16, 2021

I think it works if we have a .prettierrc on root and others with specific rules in different folders.. maybe you can try that? 😬

That could be, any rule you want in particular for BE? Maybe Gazzo can share his prettier 👀 (for reference purposes only)

@sampaiodiego
Copy link
Copy Markdown
Member

sampaiodiego commented Dec 16, 2021

I guess you can move the one from /client/.prettierrc to root and see what happens 😬

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sampaiodiego sampaiodiego mentioned this pull request Dec 21, 2021
Merged
@tassoevan tassoevan deleted the chore/poc-prettier branch September 28, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KevLehman @ggazzo @sampaiodiego @CLAassistant