[FIX] Modal keeps state if reset too fast.#23791
Merged
gabriellsh merged 5 commits intodevelopfrom Dec 7, 2021
Merged
Conversation
tassoevan
requested changes
Nov 25, 2021
Member
tassoevan
left a comment
tassoevan
left a comment
There was a problem hiding this comment.
I've suggested privately to @gabriellsh to use unique key props to ensure the modal state is dropped between two setModal() calls. It will require only the last useEffect hook.
tassoevan
approved these changes
Nov 29, 2021
This was referenced Nov 30, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Queued updates so the Modal has a chance to close.Used a random key to ensure modal doesn't keep it's state.
Issue(s)
Closes #23535
Steps to test or reproduce
Further comments