Skip to content

[NEW][APPS] Allow Rocket.Chat Apps to register custom action buttons#23679

Merged
d-gubert merged 13 commits intodevelopfrom
feat/add-ui-buttons
Dec 20, 2021
Merged

[NEW][APPS] Allow Rocket.Chat Apps to register custom action buttons#23679
d-gubert merged 13 commits intodevelopfrom
feat/add-ui-buttons

Conversation

@d-gubert
Copy link
Copy Markdown
Member

@d-gubert d-gubert commented Nov 10, 2021

Proposed changes (including videos or screenshots)

Add an action button manager that allows apps to register custom action buttons that trigger interaction callbacks in them

Issue(s)

Steps to test or reproduce

Further comments

@d-gubert
Add endpoint for fetching buttons
afa8014
@d-gubert
Add a sync manager
b7a14a7
@d-gubert
Add new websocket event
2416dab
@d-gubert
Merge remote-tracking branch 'origin/develop' into feat/add-ui-buttons
32027ca
@d-gubert
Remove unnecessary call in action event
b2cd4bb
@d-gubert
Fix reference error
4541a1d
@d-gubert
Merge branch 'develop' into feat/add-ui-buttons
2068734
@d-gubert
Merge remote-tracking branch 'origin/develop' into feat/add-ui-buttons
7c655eb
@d-gubert
Show buttons in contexts (#23724)
591e8bf 
* Show buttons in contexts

* Change tabbar filter

* Improve room type filter

* Remove testing code and refactor IRoom auxiliary functions

* Add startup loadButtons

* Trigger new UI button interactions (#23798)

* Show buttons in contexts

* Change tabbar filter

* Handle action button interactions in endpoint

* Trigger new interaction type on UI buttons
@d-gubert d-gubert changed the title [NEW] Allow Rocket.Chat Apps to register custom action buttons [NEW][APPS] Allow Rocket.Chat Apps to register custom action buttons Dec 14, 2021
@d-gubert d-gubert added this to the 4.3.0 milestone Dec 17, 2021
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@d-gubert d-gubert marked this pull request as ready for review December 20, 2021 22:35
@d-gubert d-gubert requested a review from thassiov December 20, 2021 22:39
@d-gubert d-gubert merged commit abf453f into develop Dec 20, 2021
@d-gubert d-gubert deleted the feat/add-ui-buttons branch December 20, 2021 22:41
@felipetomm
Copy link
Copy Markdown

felipetomm commented Dec 22, 2021

Hi @d-gubert
I think this new feature is awesome! But for make this more awesome, if you guys can share an gif/video in that cases of visual features, is really important for us (customers/community) 🙂

@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2021
Merged
@d-gubert
Copy link
Copy Markdown
Member Author

d-gubert commented Jan 5, 2022

Hey @felipetomm ! I think it would be nice, but what about some docs? https://developer.rocket.chat/apps-engine/fundamentals-of-apps/uikit/action-buttons 😉 😛

@felipetomm
Copy link
Copy Markdown

felipetomm commented Jan 5, 2022

Nice! Docs have all we need :)
We will use it more from now on.

Thank you for your attention @d-gubert !

@murtaza98 murtaza98 mentioned this pull request Feb 12, 2022
Open
@murtaza98
Copy link
Copy Markdown
Contributor

murtaza98 commented Feb 12, 2022

Hi Team, Indeed a very useful feature 😍 I just tested this feature & it is working perfectly on browsers but I noticed the action buttons are still not visible on the mobile app. So, any plans on adding support for this on mobile devices too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thassiov thassiov thassiov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@d-gubert @CLAassistant @felipetomm @murtaza98 @thassiov