[FIX] creating room with federated member#23347
Merged
alansikora merged 3 commits intoRocketChat:developfrom Dec 13, 2021
qwertiko:develop
Merged
[FIX] creating room with federated member#23347alansikora merged 3 commits intoRocketChat:developfrom qwertiko:develop
alansikora merged 3 commits intoRocketChat:developfrom
qwertiko:develop
Conversation
When creating a room with a federated member the local user only has the attributes "_id" and "username" for the event normalizeUser. In there the attribute emails is called but only defined two lines down. Moved the definition before the call to resolve "undefined user" error message on room creation.
|
Would be nice if we could get this reviewed and merged. |
|
This issue persists on 4.1.0-develop. Please merge. |
|
Is there any particular reason why this PR can't be reviewed and merged? |
bkraul
approved these changes
Nov 9, 2021
alansikora
approved these changes
Dec 13, 2021
ggazzo
pushed a commit
that referenced
this pull request
Dec 14, 2021
* Fix creating room with federated member When creating a room with a federated member the local user only has the attributes "_id" and "username" for the event normalizeUser. In there the attribute emails is called but only defined two lines down. Moved the definition before the call to resolve "undefined user" error message on room creation. * remove empty line (no traling spaces)
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When creating a room with a federated member the local user only has the attributes "_id" and "username" for the event normalizeUser.
In there the attribute emails is called but only defined two lines down.
Moved the definition before the call to resolve "undefined user" error message on room creation.
Issue(s)
#23250
Steps to test or reproduce
Have two servers setup with RocketChat which communicate via Federation.
Create a room with a another user from the other server.