Show messages in Team when Channel is added/removed#22420
Closed
im-adithya wants to merge 3 commits intoRocketChat:developfrom
Closed
Show messages in Team when Channel is added/removed#22420im-adithya wants to merge 3 commits intoRocketChat:developfrom
im-adithya wants to merge 3 commits intoRocketChat:developfrom
Conversation
KevLehman
requested changes
Jun 21, 2021
im-adithya
force-pushed
the
tag-channel-update
branch
from
b222f79 to
c503f4c
Compare
im-adithya
force-pushed
the
tag-channel-update
branch
from
c503f4c to
b524929
Compare
Contributor
Author
|
@KevLehman Done! Please review! |
KevLehman
reviewed
Aug 9, 2021
| import { removeUserFromRoom } from '../../../app/lib/server/functions/removeUserFromRoom'; | ||
| import { getSubscribedRoomsForUserWithDetails } from '../../../app/lib/server/functions/getRoomsWithSingleOwner'; | ||
| import type { InsertionModel } from '../../../app/models/server/raw/BaseRaw'; | ||
| import { Messages } from '../../../app/models/server'; |
Member
There was a problem hiding this comment.
Doing this would add make the service dependant on Meteor's base models, which is something we're trying to avoid. Can we replicate the changes on the Messages raw model instead? (Even if we need to duplicate some functions) 👀
Contributor
Author
There was a problem hiding this comment.
I tried doing that but there's one function (insertOrUpsert) that is hard to duplicate in BaseRaw...
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Shows the name(s) of the channels added/removed to/from Teams
Screenshots
Further comments