Skip to content

Chore: Apply generics to infer types of useForm hook#22400

Merged
tassoevan merged 4 commits intodevelopfrom
refactor/use-form-types
Jan 6, 2022
Merged

Chore: Apply generics to infer types of useForm hook#22400
tassoevan merged 4 commits intodevelopfrom
refactor/use-form-types

Conversation

@tassoevan
Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan requested a review from a team June 18, 2021 00:11
@tassoevan tassoevan changed the title Refactor: Apply generics to infer types of useForm hook Chore: Apply generics to infer types of useForm hook Jun 18, 2021
@tassoevan
Copy link
Copy Markdown
Member Author

tassoevan commented Jun 18, 2021

@sampaiodiego "Chore" is not the appropriate type here 😬
Gonna link Angular standard for reference: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

@sampaiodiego
Copy link
Copy Markdown
Member

@sampaiodiego "Chore" is not the appropriate type here
Gonna link Angular standard for reference: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit

well, they don't have chore at all.. btw, very good contributing guide..

in our case, "chore" is everything that doesn't change any aspect of the product.. does it make sense? we should have it written down btw

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@tassoevan tassoevan requested a review from a team January 6, 2022 13:25
@ggazzo ggazzo self-assigned this Jan 6, 2022
@tassoevan tassoevan merged commit 20b6116 into develop Jan 6, 2022
@tassoevan tassoevan deleted the refactor/use-form-types branch January 6, 2022 15:24
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants