[FIX] Password error should not be shown when selecting set random password#21181
Merged
dougfabris merged 7 commits intoRocketChat:developfrom Jan 6, 2022
Merged
[FIX] Password error should not be shown when selecting set random password#21181dougfabris merged 7 commits intoRocketChat:developfrom
dougfabris merged 7 commits intoRocketChat:developfrom
Conversation
Member
|
@yash-rajpal can you take a look at this conflict, please? |
Member
Author
|
@dougfabris Sure, I will take care of the conflicts. 👍 |
pierre-lehnen-rc
approved these changes
Jan 4, 2022
dougfabris
approved these changes
Jan 6, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
We should not keep
passwordas required field when we check set random password field. In this password should not be requiredIssue(s)
Closes #21179
Steps to test or reproduce
Further comments
So checking

setRandomPasswordbefore setting password error.