Skip to content

[FIX] Password error should not be shown when selecting set random password#21181

Merged
dougfabris merged 7 commits intoRocketChat:developfrom
yash-rajpal:fix-21179
Jan 6, 2022
Merged

[FIX] Password error should not be shown when selecting set random password#21181
dougfabris merged 7 commits intoRocketChat:developfrom
yash-rajpal:fix-21179

Conversation

@yash-rajpal
Copy link
Copy Markdown
Member

@yash-rajpal yash-rajpal commented Mar 18, 2021

  • I have read the Contributing Guide
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

We should not keep password as required field when we check set random password field. In this password should not be required

Issue(s)

Closes #21179

Steps to test or reproduce

Further comments

So checking setRandomPassword before setting password error.
fix-21179 after

@KevLehman KevLehman requested a review from a team April 30, 2021 14:41
@dougfabris
Copy link
Copy Markdown
Member

@yash-rajpal can you take a look at this conflict, please?

@yash-rajpal
Copy link
Copy Markdown
Member Author

@dougfabris Sure, I will take care of the conflicts. 👍

@dougfabris dougfabris merged commit 7ee8c4b into RocketChat:develop Jan 6, 2022
@dougfabris dougfabris added this to the 4.4.0 milestone Jan 10, 2022
@sampaiodiego sampaiodiego mentioned this pull request Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User creation: Password required even if set random password is selected

3 participants