Skip to content

[FIX] Forgot password endpoint return status#19842

Merged
sampaiodiego merged 2 commits intodevelopfrom
improve/omit-error-messages-in-forgot-password
Dec 14, 2020
Merged

[FIX] Forgot password endpoint return status#19842
sampaiodiego merged 2 commits intodevelopfrom
improve/omit-error-messages-in-forgot-password

Conversation

@gabrieleiro
Copy link
Copy Markdown
Contributor

@gabrieleiro gabrieleiro commented Dec 11, 2020

  • respond with status 200 for account not found
  • change tests

Proposed changes

forgot password endpoint responds with 200 even if user was not found.

Issue(s)

How to test or reproduce

post a non existent user to the users.forgotPassword endpoint

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@gabrieleiro gabrieleiro changed the title [IMPROVE] fotgot password endpoint return status code 200 if user was not found [IMPROVE] forgot password endpoint return status code 200 if user was not found Dec 11, 2020
@sampaiodiego sampaiodiego changed the title [IMPROVE] forgot password endpoint return status code 200 if user was not found [IMPROVE] Forgot password endpoint return status to return as success regardless if email was found or not Dec 14, 2020
@sampaiodiego sampaiodiego merged commit bf88a0e into develop Dec 14, 2020
@sampaiodiego sampaiodiego deleted the improve/omit-error-messages-in-forgot-password branch December 14, 2020 13:48
@sampaiodiego sampaiodiego changed the title [IMPROVE] Forgot password endpoint return status to return as success regardless if email was found or not [FIX] Forgot password endpoint return status Dec 17, 2020
@sampaiodiego sampaiodiego added this to the 3.9.2 milestone Dec 17, 2020
@sampaiodiego sampaiodiego mentioned this pull request Dec 17, 2020
Merged
sampaiodiego pushed a commit that referenced this pull request Dec 17, 2020
@gabrieleiro @sampaiodiego
[IMPROVE] Forgot password endpoint return status to return as success…
f70c77a 
… regardless if email was found or not (#19842)
sampaiodiego pushed a commit that referenced this pull request Dec 17, 2020
@gabrieleiro @sampaiodiego
[IMPROVE] Forgot password endpoint return status to return as success…
13a1c92 
… regardless if email was found or not (#19842)
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.9.2

Development

Successfully merging this pull request may close these issues.

2 participants

@gabrieleiro @sampaiodiego