Skip to content

Regression: Accept visitors for uikit interactions#18706

Merged
sampaiodiego merged 6 commits intodevelopfrom
uikit/livechat-widget-events
Aug 29, 2020
Merged

Regression: Accept visitors for uikit interactions#18706
sampaiodiego merged 6 commits intodevelopfrom
uikit/livechat-widget-events

Conversation

@d-gubert
Copy link
Copy Markdown
Member

@d-gubert d-gubert commented Aug 27, 2020 •
edited
Loading

Proposed changes

This PR enables Livechat visitors to interact with UIKit blocks in the widget

RocketChat/Rocket.Chat.Apps-engine#305

This small app has been used for testing purposes https://github.com/d-gubert/conditional-block-test

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@d-gubert d-gubert requested a review from sampaiodiego August 27, 2020 22:38
@d-gubert d-gubert added this to the 3.6.0 milestone Aug 27, 2020
@d-gubert d-gubert marked this pull request as draft August 27, 2020 22:39
@d-gubert d-gubert mentioned this pull request Aug 27, 2020
Merged
sampaiodiego
sampaiodiego requested changes Aug 28, 2020
View reviewed changes
ggazzo
ggazzo previously approved these changes Aug 28, 2020
View reviewed changes
@d-gubert d-gubert marked this pull request as ready for review August 29, 2020 00:20
@sampaiodiego sampaiodiego merged commit b881005 into develop Aug 29, 2020
@sampaiodiego sampaiodiego deleted the uikit/livechat-widget-events branch August 29, 2020 01:51
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@ggazzo ggazzo ggazzo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@d-gubert @ggazzo @sampaiodiego