Skip to content

Regression: Omnichannel Tags and Units issues#18705

Merged
ggazzo merged 2 commits intodevelopfrom
omni/tags-unit-reg
Aug 28, 2020
Merged

Regression: Omnichannel Tags and Units issues#18705
ggazzo merged 2 commits intodevelopfrom
omni/tags-unit-reg

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

Proposed changes

  • Fixes multiselects breaking the page on Tags and Units pages
  • Adds Confirmation modals to both Tags and Units removal
  • Fixes issue that had multiselect completely filled when creating a unit

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@MartinSchoeler MartinSchoeler added type: bug area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction labels Aug 27, 2020
@MartinSchoeler MartinSchoeler requested a review from a team August 27, 2020 18:15
@tassoevan tassoevan changed the title [REGRESSION] Omnichannel Tags and Units Regressions Regression: Omnichannel Tags and Units issues Aug 28, 2020
@ggazzo ggazzo merged commit dfd9041 into develop Aug 28, 2020
@ggazzo ggazzo deleted the omni/tags-unit-reg branch August 28, 2020 13:54
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction type: bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants