Skip to content

[NEW] Export room messages as file or directly via email#18606

Merged
sampaiodiego merged 36 commits intodevelopfrom
export-messages
Aug 22, 2020
Merged

[NEW] Export room messages as file or directly via email#18606
sampaiodiego merged 36 commits intodevelopfrom
export-messages

Conversation

@sampaiodiego
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego commented Aug 19, 2020

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 19, 2020

This pull request introduces 4 alerts when merging 69d6a65 into dc549a5 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class
  • 1 for Superfluous trailing arguments

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 19, 2020

This pull request introduces 3 alerts when merging ec537d9 into dc549a5 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 19, 2020

This pull request introduces 1 alert when merging 364bb76 into dc549a5 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@sampaiodiego sampaiodiego changed the title [IMPROVE] Export messages [NEW] Export messages Aug 19, 2020
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 19, 2020

This pull request introduces 1 alert when merging d37b126 into 452589f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 20, 2020

This pull request introduces 3 alerts when merging 113b47a into 452589f - view on LGTM.com

new alerts:

  • 2 for Potentially inconsistent state update
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 20, 2020

This pull request introduces 3 alerts when merging 423be29 into 452589f - view on LGTM.com

new alerts:

  • 2 for Potentially inconsistent state update
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 20, 2020

This pull request introduces 1 alert when merging 4b7d461 into a0a4948 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Aug 20, 2020

This pull request introduces 1 alert when merging e8ae74b into bce223a - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@sampaiodiego sampaiodiego marked this pull request as ready for review August 21, 2020 05:25
@sampaiodiego sampaiodiego added this to the 3.6.0 milestone Aug 21, 2020
rodrigok
rodrigok requested changes Aug 21, 2020
View reviewed changes
rodrigok
rodrigok requested changes Aug 21, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@rodrigok rodrigok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Missing feedback when click to send messages
  2. Date fields are large than the bar
  3. Missing feedback on the export as well
  4. Email subject not translated Channel_Export

@sampaiodiego sampaiodiego requested a review from rodrigok August 21, 2020 21:20
@rodrigok rodrigok changed the title [NEW] Export messages [NEW] Export room messages as file or via directly via email Aug 22, 2020
@sampaiodiego sampaiodiego changed the title [NEW] Export room messages as file or via directly via email [NEW] Export room messages as file or directly via email Aug 22, 2020
@sampaiodiego sampaiodiego merged commit 5f17be5 into develop Aug 22, 2020
@sampaiodiego sampaiodiego deleted the export-messages branch August 22, 2020 01:05
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok rodrigok approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

@pierre-lehnen-rc pierre-lehnen-rc Awaiting requested review from pierre-lehnen-rc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sampaiodiego @rodrigok @ggazzo