Skip to content

[FIX] findOrCreateInvite REST endpoint ignoring days and maxUses params#18565

Merged
sampaiodiego merged 2 commits intodevelopfrom
fix.invite-api
Aug 22, 2020
Merged

[FIX] findOrCreateInvite REST endpoint ignoring days and maxUses params#18565
sampaiodiego merged 2 commits intodevelopfrom
fix.invite-api

Conversation

@pierre-lehnen-rc
Copy link
Copy Markdown
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Aug 14, 2020 •
edited
Loading

Proposed changes

Issue(s)

Closes #18333

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@pierre-lehnen-rc pierre-lehnen-rc added this to the 4.0.0 milestone Aug 14, 2020
RonyVidaur
RonyVidaur reviewed Aug 15, 2020
View reviewed changes
RonyVidaur
RonyVidaur reviewed Aug 15, 2020
View reviewed changes
RonyVidaur
RonyVidaur reviewed Aug 15, 2020
View reviewed changes
@pierre-lehnen-rc pierre-lehnen-rc modified the milestones: 4.0.0, 3.6.0 Aug 19, 2020
@sampaiodiego sampaiodiego changed the title [FIX] findOrCreateInvite API method ignoring days and maxUses params [FIX] findOrCreateInvite REST endpoint ignoring days and maxUses params Aug 22, 2020
@sampaiodiego sampaiodiego merged commit 41ca8be into develop Aug 22, 2020
@sampaiodiego sampaiodiego deleted the fix.invite-api branch August 22, 2020 01:02
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

+1 more reviewer

@RonyVidaur RonyVidaur RonyVidaur left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

Bug with findOrCreateInvite on the API

3 participants

@pierre-lehnen-rc @sampaiodiego @RonyVidaur