[FIX] Read receipts duplicate key error#18560
Merged
sampaiodiego merged 5 commits intoRocketChat:developfrom Aug 18, 2020
galshiff:develop
Merged
[FIX] Read receipts duplicate key error#18560sampaiodiego merged 5 commits intoRocketChat:developfrom galshiff:develop
sampaiodiego merged 5 commits intoRocketChat:developfrom
galshiff:develop
Conversation
sampaiodiego
requested changes
Aug 14, 2020
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
that's an awesome find @galshiff .. thank you!
I was able to reproduce the issue doing what you described, marking room as unread and then coming back and sending a message right away.. good catch 👍
please look at my code comments.. thx again
sampaiodiego
approved these changes
Aug 18, 2020
sampaiodiego
changed the title
Merged
|
Not sure if it's related, but after the Update to 3.6 I see this problem: #18689 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The receipt duplicate key error bug crashes the rocket chat instance because this exception is not being catch by the 'try-catch' block.
The fix is to catch this exception on the callback of insertMany.
Issue(s)
#17045
How to test or reproduce
This bug occurs from time to time on regular base inside chats...
I also managed to reproduce this bug sometimes when I marked as unread a chat from the sidebar,
and then I returned to this chat and got the duplicate key error message & my RC instance crashed.
Screenshots
Types of changes
Checklist
Changelog
Fixed receipt duplicate key error bug
Further comments