Skip to content

Regression: Fix room avatar file name#18544

Merged
ggazzo merged 1 commit intodevelopfrom
fix-channel-avatar
Aug 13, 2020
Merged

Regression: Fix room avatar file name#18544
ggazzo merged 1 commit intodevelopfrom
fix-channel-avatar

Conversation

@sampaiodiego
Copy link
Copy Markdown
Member

Proposed changes

Channel avatars files were being stored as undefined so now the will be saved as room-RoomId

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego requested a review from ggazzo August 13, 2020 03:49
@ggazzo ggazzo merged commit 798ce4f into develop Aug 13, 2020
@ggazzo ggazzo deleted the fix-channel-avatar branch August 13, 2020 12:34
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants