Skip to content

Types for Fuselage, contexts and some Omnichannel components#18520

Merged
ggazzo merged 16 commits intoref/omnifrom
ref/omni-ts
Aug 12, 2020
Merged

Types for Fuselage, contexts and some Omnichannel components#18520
ggazzo merged 16 commits intoref/omnifrom
ref/omni-ts

Conversation

@tassoevan
Copy link
Copy Markdown
Member

@tassoevan tassoevan commented Aug 10, 2020

Proposed changes

It adds a prototype for declarations of Fuselage components, as well converts some modules for React contexts to TypeScript. meteor/kadira:flow-router will be slightly typed too.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan changed the title Ref/omni ts Types for Fuselage, contexts and some Omnichannel components Aug 12, 2020
@tassoevan tassoevan requested a review from a team August 12, 2020 14:01
@tassoevan tassoevan marked this pull request as ready for review August 12, 2020 14:03
@ggazzo ggazzo merged commit 87854e9 into ref/omni Aug 12, 2020
@ggazzo ggazzo deleted the ref/omni-ts branch August 12, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants