Skip to content

[FIX] SMS integration not storing media files#18491

Merged
sampaiodiego merged 10 commits intodevelopfrom
omnichannel/fix-twilio-not-storing-uploads
Aug 22, 2020
Merged

[FIX] SMS integration not storing media files#18491
sampaiodiego merged 10 commits intodevelopfrom
omnichannel/fix-twilio-not-storing-uploads

Conversation

@renatobecker
Copy link
Copy Markdown
Contributor

@renatobecker renatobecker commented Aug 5, 2020

Proposed changes

The SMS/WhatsApp integration isn't storing uploaded files, the current implementation is just storing the SMS media URL as a message attachment and this is the reason we aren't able to get the fileUpload data through the Apps-Engine because the file field is missing.
Now, the integration will store the media files properly, not just store the file but also link it to messages.

Issue(s)

How to test or reproduce

  • Active the SMS integration
  • Setup Twilio integration
  • Send/Share files through WhatsApp
  • The file will be stored properly

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@renatobecker renatobecker added this to the 3.6.0 milestone Aug 5, 2020
@renatobecker renatobecker changed the title [FIX] SMS integration is not storing uploaded files [FIX] SMS integration is not storing media files Aug 9, 2020
Copy link
Copy Markdown
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry the late re-review :(

@sampaiodiego sampaiodiego changed the title [FIX] SMS integration is not storing media files [FIX] SMS integration not storing media files Aug 21, 2020
@sampaiodiego sampaiodiego merged commit e2e5322 into develop Aug 22, 2020
@sampaiodiego sampaiodiego deleted the omnichannel/fix-twilio-not-storing-uploads branch August 22, 2020 00:54
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants