[FIX] SMS integration not storing media files#18491
Merged
sampaiodiego merged 10 commits intodevelopfrom Aug 22, 2020
Merged
Conversation
sampaiodiego
requested changes
Aug 6, 2020
sampaiodiego
requested changes
Aug 19, 2020
Member
sampaiodiego
left a comment
There was a problem hiding this comment.
I'm sorry the late re-review :(
sampaiodiego
approved these changes
Aug 20, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The SMS/WhatsApp integration isn't storing uploaded files, the current implementation is just storing the SMS media URL as a message attachment and this is the reason we aren't able to get the
fileUploaddata through theApps-Enginebecause thefilefield is missing.Now, the integration will store the media files properly, not just store the file but also link it to messages.
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments