Skip to content

[FIX] Migration 194#18457

Merged
sampaiodiego merged 1 commit intoRocketChat:developfrom
thirsch:bugfix/migration-v194-broken-if-no-saml-config-found
Aug 1, 2020
Merged

[FIX] Migration 194#18457
sampaiodiego merged 1 commit intoRocketChat:developfrom
thirsch:bugfix/migration-v194-broken-if-no-saml-config-found

Conversation

@thirsch
Copy link
Copy Markdown
Contributor

@thirsch thirsch commented Aug 1, 2020 •
edited
Loading

Proposed changes

Fixing the bug in migration v194, which prevented me from upgrading.

Issue(s)

Not sure, if there was an open issue.

How to test or reproduce

Migrating from v193 to v194 without having a settings entry for id "SAML_Custom_Default_user_data_fieldmap".

Screenshots

not adequate

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Fixed migration v194; in cases there is no SAML configuration, the database couldn't be migrated from v193 to v194.

Further comments

not required

@sampaiodiego
Copy link
Copy Markdown
Member

sampaiodiego commented Aug 1, 2020

thanks @thirsch .. just we know, from which version did you try to upgrade and got an error?

@sampaiodiego sampaiodiego changed the title [FIX] Bugfix for migration v194.js [FIX] Migration 194 Aug 1, 2020
@sampaiodiego sampaiodiego merged commit f19f489 into RocketChat:develop Aug 1, 2020
@thirsch
Copy link
Copy Markdown
Contributor Author

thirsch commented Aug 1, 2020

@sampaiodiego is there an easy way to see migrations based on dates? Because I tried the upgrade multiple times before I recognized, that using the docker image migrates version by version and just crashed while applying version v194. So my database was v193 since the very first try and all my logs I still have, just show this try again and again. I guess I'm missing the first log on upgrading from whatever version I had before.

sampaiodiego pushed a commit that referenced this pull request Aug 1, 2020
@thirsch @sampaiodiego
[FIX] Migration 194 (#18457)
af6988e
@sampaiodiego sampaiodiego mentioned this pull request Aug 1, 2020
Merged
@sampaiodiego
Copy link
Copy Markdown
Member

sampaiodiego commented Aug 1, 2020

There is no easy way to see migrations based on dates, but from I what I saw migration 194 was introduced on version 3.4.0..

I'll be releasing this fix on version 3.5.1 today, so you'll be able to upgrade to 3.5.1, you'll only need to unlock the migration direct via DB.. you can use the following query:

db.migrations.update({}, { $set: { locked: false } })

gabriellsh added a commit that referenced this pull request Aug 10, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into ref/…
4013527 
…omni

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Add REST API endpoint to search Livechat visitors (#18514)
  LingoHub based on develop (#18516)
  Update README.md (#18503)
  [NEW] Channel avatar (#18443)
  [FIX] Sending notifications from senders without a name (#18479)
  [FIX] UserCard avatar cache (avatarETag) (#18466)
  [IMPROVE] Admin Info page requires permission (#18408)
  [FIX] Marking room as read with unread threads still (#18410)
  [FIX] Random generated password not matching the Password Policy (#18475)
  Typo in privacy agreement message (#18476)
  bugfix for uploading files from livechat (#18474)
  LingoHub based on develop (#18465)
  [NEW] Add the ability to set the character message limit on Livechat widget (#18261)
  [FIX] Migration 194 (#18457)
  [FIX] Omnichannel session monitor is not starting (#18412)
  [FIX] Invalid MIME type when uploading audio files (#18426)
  [FIX] Error when updating omnichannel department without agents parameter (#18428)
  [FIX] Omnichannel Take Inquiry endpoint checking wrong permission (#18446)
  [FIX] Multiple push notifications sent via native drivers (#18442)
  [FIX] Appending 'false' to Jitsi URL (#18430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thirsch @sampaiodiego