This pull request introduces 3 alerts when merging 25ec0ee into 55703f1 - view on LGTM.com

new alerts:

• 3 for Unused variable, import, function or class

I can upload other file formats and break the server if i upload a .pdf this happens:

and I get this error on the server console

W20200730-20:33:10.278(-3)? (STDERR) === UnHandledPromiseRejection ===
W20200730-20:33:10.279(-3)? (STDERR) [Error: Input file contains unsupported image format]
W20200730-20:33:10.279(-3)? (STDERR) ---------------------------------
W20200730-20:33:10.279(-3)? (STDERR) Errors like this can cause oplog processing errors.
W20200730-20:33:10.279(-3)? (STDERR) Setting EXIT_UNHANDLEDPROMISEREJECTION will cause the process to exit allowing your service to automatically restart the process
W20200730-20:33:10.279(-3)? (STDERR) Future node.js versions will automatically exit the process
W20200730-20:33:10.279(-3)? (STDERR) =================================

Also if this is done not from the admin view the saving fails and the browser gives this error:

Exception in setTimeout callback: TypeError: Cannot read property 'etag' of undefined
I20200730-20:44:02.133(-3)?     at app/lib/server/functions/setRoomAvatar.js:66:45
I20200730-20:44:02.139(-3)?     at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12)
I20200730-20:44:02.140(-3)?     at packages/meteor.js:550:25
I20200730-20:44:02.140(-3)?     at runWithEnvironment (packages/meteor.js:1286:24)

no server crashes this time

it seems like to wrong issue number was mentioned and an unrelated issue was closed

thanks for pointing it out @Exordian .. but the issue was indeed closed by this specific commit (ecd306c) included in this PR, although they seem unrelated 👍

In Directory search the avatars not shown.

I install 3.6.0 and have this problem.

me too

Also if this is done not from the admin view the saving fails and the browser gives this error:

In the logs of 3.7.1 the same error appears and as well only, when non-admins are trying to upload an avatar. For admins the feature works as expected.

@BjoernLudwigPTB you can test the release candidate for 3.8.0 .. https://github.com/RocketChat/Rocket.Chat/releases/tag/3.8.0-rc.5

@BjoernLudwigPTB you can test the release candidate for 3.8.0 .. https://github.com/RocketChat/Rocket.Chat/releases/tag/3.8.0-rc.5

Unfortunately I myself cannot. In my organisation I am only administrator on the application side, the deployment is done by colleagues. I asked them to have a look and will report.

It would be great to be able to set the custom Avatar via API, similarly to
/api/v1/users.setAvatar

In theory you should be able to do that using the rooms.saveRoomSettings endpoint (which is not documented).. but I agree we having a rooms.setAvatar endpoint makes sense.. we're open for contributions =)

Hi Diego, thanks for your comment. You mean using an undocumented API REST endpoint or you mean the Realtime API? could you share an example call setting an avatarUrl to a rid? thanks

@didacroyo you can do either.. there is an endpoint at /api/v1/rooms.saveRoomSettings that accepts the same payload as the Realtime Method called saveRoomSettings.. you can check the source code at

you can send a payload with roomAvatar field which should work the same as using the users.setAvatar endpoint 😉

Just tried adding a channel icon to three different channels on the server. Only 1 time it worked. I am using the latest snap (3.10.5) on Ubuntu 20.04.2 LTS. Not sure why it doesn't work, as my manual installation of another RocketChat server (3.12.0, same droplet specs) never has an issue updating the channel icons. I have tried PNGs, GIFs, and JPGs on both the admin and user interface - nothing seems to work consistently.

EDIT: Apparently others on the server can see the channel icons, but not me even after refreshing and ignoring cache, outright closing RocketChat and starting it again, or rebooting the entire server. Odd.

Hi, @sampaiodiego

We are using our API to change the avatar of the rooms; but despite of all our efforts, it returns

{ "rid": "REAL_ROOM_ID", "success": true }

The response is 200 ok; but the avatar in the room isn't changed, even if we restart the service or reload without cache. We are sending this using PHP

$curl = curl_init();

curl_setopt_array($curl, array(
  CURLOPT_URL => 'https://OUR_CHAT/api/v1/rooms.saveRoomSettings',
  CURLOPT_RETURNTRANSFER => true,
  CURLOPT_ENCODING => '',
  CURLOPT_MAXREDIRS => 10,
  CURLOPT_TIMEOUT => 0,
  CURLOPT_FOLLOWLOCATION => true,
  CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1,
  CURLOPT_CUSTOMREQUEST => 'POST',
  CURLOPT_POSTFIELDS =>'{
"rid": "REAL_ROOM_ID",
"roomAvatar":"VALID_IMAGE_URL"
}',
  CURLOPT_HTTPHEADER => array(
    'X-User-Id: REAL_ID_API',
    'X-Auth-Token: REAL_TOKEN',
    'Content-Type: application/json'
  ),
));

$response = curl_exec($curl);

curl_close($curl);
echo $response;

And we know that it somehow works, because we can send the key "roomName" and it successfully changes the name; but the image is never shown!!!

Thank you in advance for your help. Regards

hi @ArturoRejon , I'm sorry the delay..

looks like the endpoint accepts a base64 for room avatar only, despite my previous comments and the documentation..

so instead of VALID_IMAGE_URL you'll need to parse the image content and provide a base64 payload, something like:

roomAvatar: "data:image/png;base64,iVBORw0KGg ...... "

@sampaiodiego thank you, it works!!