Skip to content

[FIX] Auto complete user suggestions#18437

Merged
ggazzo merged 4 commits intodevelopfrom
fix-user-popup
Aug 19, 2020
Merged

[FIX] Auto complete user suggestions#18437
ggazzo merged 4 commits intodevelopfrom
fix-user-popup

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented Jul 30, 2020 •
edited
Loading

Proposed changes

Fixes the issue with broken user suggestions in threads when using @

Issue(s)

Screenshots

Screen Shot 2020-07-30 at 1 10 20 PM

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Fixes the issue with broken user suggestions in threads when using @

Further comments

Pls avoid float :)

@MartinSchoeler MartinSchoeler added the area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction label Jul 30, 2020
@MartinSchoeler MartinSchoeler added this to the 3.6.0 milestone Jul 30, 2020
@MartinSchoeler MartinSchoeler requested a review from a team July 30, 2020 17:04
@ggazzo ggazzo changed the title [FIX] User suggestions [FIX] User suggestions Jul 30, 2020
@ggazzo ggazzo changed the title [FIX] User suggestions [FIX] Auto complete user suggestions Jul 30, 2020
@ggazzo ggazzo merged commit fdda142 into develop Aug 19, 2020
@ggazzo ggazzo deleted the fix-user-popup branch August 19, 2020 07:11
tassoevan added a commit that referenced this pull request Aug 22, 2020
@tassoevan
Refactor: Omnichannel Current Chats (#18627)
c6c96f4 
Squashed commit of the following:

commit 3d28fb9
Author: Guilherme Gazzo <[email protected]>
Date:   Fri Aug 21 17:25:15 2020 -0300

    Review

commit b560888
Merge: 2e5417c 40c7226
Author: Guilherme Gazzo <[email protected]>
Date:   Fri Aug 21 17:05:37 2020 -0300

    Merge branch 'ref/omni' of github.com:RocketChat/Rocket.Chat into ref/omni-curr-chats

commit 40c7226
Merge: ab78f68 575df22
Author: Guilherme Gazzo <[email protected]>
Date:   Fri Aug 21 17:04:51 2020 -0300

    Merge branch 'develop' into ref/omni

commit 2e5417c
Merge: da8388b 6b04ba5
Author: Guilherme Gazzo <[email protected]>
Date:   Fri Aug 21 16:23:21 2020 -0300

    Merge branch 'ref/omni-curr-chats' of github.com:RocketChat/Rocket.Chat into ref/omni-curr-chats

commit da8388b
Merge: 07f2e89 ab78f68
Author: Guilherme Gazzo <[email protected]>
Date:   Fri Aug 21 16:22:43 2020 -0300

    Merge branch 'ref/omni' of github.com:RocketChat/Rocket.Chat into ref/omni-curr-chats

commit 575df22
Author: Anton Kazarinov <[email protected]>
Date:   Fri Aug 21 23:31:45 2020 +0500

    [IMPROVE] Slack bridge: add support to threads (#15992)

    Co-authored-by: Rodrigo Nascimento <[email protected]>
    Co-authored-by: pierre-lehnen-rc <[email protected]>

commit 40520f4
Author: Douglas Gubert <[email protected]>
Date:   Fri Aug 21 15:16:10 2020 -0300

    [NEW][APPS-ENGINE] Implement new IPostLivechatRoomTransferred event (#18625)

    * Implement new IPostLivechatRoomTransferred event

    * Move event trigger to correct place

    * Update Apps-Engine version

commit ab78f68
Merge: 3aca1b0 06467a6
Author: Guilherme Gazzo <[email protected]>
Date:   Fri Aug 21 13:57:53 2020 -0300

    Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into ref/omni

commit 6b04ba5
Author: Martin <[email protected]>
Date:   Fri Aug 21 03:39:05 2020 -0300

    Remove old files

commit 47c92ce
Author: Martin <[email protected]>
Date:   Fri Aug 21 03:33:21 2020 -0300

    Revert develop merge

commit 4a23db7
Author: Martin <[email protected]>
Date:   Fri Aug 21 03:27:45 2020 -0300

    add tags

commit 06467a6
Author: Guilherme Gazzo <[email protected]>
Date:   Fri Aug 21 03:10:31 2020 -0300

    [IMPROVE] UserCard and UserInfo Show Real Names Setting (#18628)

commit ebcfbd3
Author: Martin <[email protected]>
Date:   Fri Aug 21 01:30:35 2020 -0300

    remove test data

commit 07f2e89
Author: Guilherme Gazzo <[email protected]>
Date:   Fri Aug 21 01:25:12 2020 -0300

    Fix

commit 7cb736b
Merge: d7840be 7d60bee
Author: Guilherme Gazzo <[email protected]>
Date:   Fri Aug 21 00:48:02 2020 -0300

    Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into ref/omni-curr-chats

commit d7840be
Author: Martin <[email protected]>
Date:   Fri Aug 21 00:21:26 2020 -0300

    use old url

commit cfb5a33
Author: Martin <[email protected]>
Date:   Fri Aug 21 00:09:45 2020 -0300

    lint

commit 2cfbafb
Author: Martin <[email protected]>
Date:   Fri Aug 21 00:08:27 2020 -0300

    Current Chats wip

commit 7d60bee
Author: Guilherme Gazzo <[email protected]>
Date:   Thu Aug 20 22:45:51 2020 -0300

    [FIX] MarkdownText usage (#18621)

commit 3aca1b0
Author: gabriellsh <[email protected]>
Date:   Thu Aug 20 22:43:22 2020 -0300

    Refactor: Omnichannel Facebook Integration (#18624)

    Co-authored-by: Guilherme Gazzo <[email protected]>

commit 528fbe7
Author: Marcos Spessatto Defendi <[email protected]>
Date:   Thu Aug 20 22:42:05 2020 -0300

    Anonymous user were being created based on manually approve users (#17427)

commit 88649be
Author: gabriellsh <[email protected]>
Date:   Thu Aug 20 22:14:08 2020 -0300

    Fix Triggers (#18626)

commit abae419
Author: Rodrigo Nascimento <[email protected]>
Date:   Thu Aug 20 22:00:41 2020 -0300

    Update dependencies (#18593)

commit 09b825d
Author: pierre-lehnen-rc <[email protected]>
Date:   Thu Aug 20 21:15:39 2020 -0300

    [NEW] Banner for servers in the middle of the registration process (#18623)

commit bce223a
Author: Murtaza Patrawala <[email protected]>
Date:   Fri Aug 21 04:11:42 2020 +0530

    [NEW]Add new endpoint to change Omnichannel room's visitor (#18528)

    * add new endpoint to change room visitor

    * Apply suggestions from code review

    Co-authored-by: Renato Becker <[email protected]>

    * fix errors in previous commit

    * modify livechat.config endpoint to support new param - roomId

    * Apply suggestions from code review

    Co-authored-by: Renato Becker <[email protected]>

    * remove changes to livechat-config endpoint

    * move permission check into Livechat lib

    * refactor code

    * Apply suggestions from code review

    Co-authored-by: Renato Becker <[email protected]>

    * query optimization and fix return value

    * return whole room object

    * limit room fields from while loading from DB

    * Remove unecessary promise statement.

    Co-authored-by: Renato Becker <[email protected]>

commit a0a4948
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Aug 20 14:10:47 2020 -0300

    Bump bcrypt from 3.0.7 to 5.0.0 (#18622)

    Bumps [bcrypt](https://github.com/kelektiv/node.bcrypt.js) from 3.0.7 to 5.0.0.
    - [Release notes](https://github.com/kelektiv/node.bcrypt.js/releases)
    - [Changelog](https://github.com/kelektiv/node.bcrypt.js/blob/master/CHANGELOG.md)
    - [Commits](kelektiv/node.bcrypt.js@v3.0.7...v5.0.0)

    Signed-off-by: dependabot[bot] <[email protected]>

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 4a2636d
Author: Paulo Bernardo <[email protected]>
Date:   Thu Aug 20 11:45:56 2020 -0300

    [FIX] Agents enabledDepartment attribute not set on collection (#18614)

commit 28cf942
Author: jbguerraz <[email protected]>
Date:   Thu Aug 20 14:43:29 2020 +0200

    [IMPROVE] Jitsi room name hash or plain (#17481)

commit 452589f
Author: Diego Sampaio <[email protected]>
Date:   Wed Aug 19 20:22:40 2020 -0300

    Explain why issue is closed when not using an issue template (#18420)

commit b491b26
Author: Rodrigo Nascimento <[email protected]>
Date:   Wed Aug 19 18:36:51 2020 -0300

    Prevent directory API to return emails if the user has no permission (#18478)

commit 0a2d8ca
Author: Rodrigo Nascimento <[email protected]>
Date:   Wed Aug 19 18:20:16 2020 -0300

    Set default timeout of 20s for HTTP calls (#18549)

commit 0e2309e
Author: Guilherme Gazzo <[email protected]>
Date:   Wed Aug 19 18:07:36 2020 -0300

    [FIX] UIKit Select and Multiselects not working (#18598)

commit dc549a5
Author: Martin Schoeler <[email protected]>
Date:   Wed Aug 19 10:27:34 2020 -0300

    [IMPROVE] Add agentId parameter to changeLivechatStatus method (#18571)

    * Add agentId parameter to changeLivechatStatus method

    * Fix reviews

    * fix problems

    * return if the same as before

    * Update app/livechat/server/methods/changeLivechatStatus.js

    Co-authored-by: Renato Becker <[email protected]>

    * Fix review

    Co-authored-by: Guilherme Gazzo <[email protected]>
    Co-authored-by: Renato Becker <[email protected]>
    Co-authored-by: Guilherme Gazzo <[email protected]>

commit fdda142
Author: Martin Schoeler <[email protected]>
Date:   Wed Aug 19 04:11:26 2020 -0300

    [FIX] Auto complete user suggestions (#18437)

    Co-authored-by: Tasso Evangelista <[email protected]>
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

area: ui/ux Related to UI/UX, frontend code, accessibility, and user interaction

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@MartinSchoeler @ggazzo @tassoevan