Skip to content

[FIX] Missing Privacy Terms Cloud Register warning#18383

Merged
sampaiodiego merged 1 commit intodevelopfrom
cloudTerms
Jul 27, 2020
Merged

[FIX] Missing Privacy Terms Cloud Register warning#18383
sampaiodiego merged 1 commit intodevelopfrom
cloudTerms

Conversation

@gabriellsh
Copy link
Copy Markdown
Member

@gabriellsh gabriellsh commented Jul 27, 2020

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo added this to the 3.6.0 milestone Jul 27, 2020
@rodrigok rodrigok changed the title [NEW] Privacy Terms Cloud Register warning [FIX] Missing Privacy Terms Cloud Register warning Jul 27, 2020
@sampaiodiego sampaiodiego merged commit e1f0dc7 into develop Jul 27, 2020
@sampaiodiego sampaiodiego deleted the cloudTerms branch July 27, 2020 20:00
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Merged
@geekgonecrazy
Copy link
Copy Markdown
Contributor

geekgonecrazy commented Jul 28, 2020 •
edited
Loading

Curious.. why this instead of just putting that setting here too to make for good UX? This makes for kinda bad UX having to go dig through to another seemingly random screen. Honestly beyond this.. I can't think of a single other reason an admin would ever view the wizard setup settings page.

@sampaiodiego
Copy link
Copy Markdown
Member

sampaiodiego commented Jul 28, 2020

you're right @geekgonecrazy .. I asked @rodrigok about this and he said this screen will be completely re-written, so they decided to make the easiest thing to waste less work possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rodrigok rodrigok rodrigok approved these changes

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@gabriellsh @geekgonecrazy @sampaiodiego @rodrigok @ggazzo