[IMPROVE] Change setting that blocks unauthenticated access to avatar to public#18316
Merged
sampaiodiego merged 3 commits intoRocketChat:developfrom Jul 21, 2020
djorkaeffalexandre:improve.avatar-auth
Merged
[IMPROVE] Change setting that blocks unauthenticated access to avatar to public#18316sampaiodiego merged 3 commits intoRocketChat:developfrom djorkaeffalexandre:improve.avatar-auth
sampaiodiego merged 3 commits intoRocketChat:developfrom
djorkaeffalexandre:improve.avatar-auth
Conversation
sampaiodiego
approved these changes
Jul 21, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ting
Proposed changes
Clients can get this setting and know if should send the authorization params or not.
Issue(s)
How to test or reproduce
Try to get the public settings and see if it's listed.
Screenshots
Types of changes
Checklist
Changelog
Turn Accounts_AvatarBlockUnauthenticatedAccess a public setting, so, the clients can know if should send the authorization params or not.
Further comments