Skip to content

[FIX] Error when fetching a nonexistent business hour from the server#18315

Merged
sampaiodiego merged 4 commits intodevelopfrom
omnichannel/fix-business-hour-error
Jul 21, 2020
Merged

[FIX] Error when fetching a nonexistent business hour from the server#18315
sampaiodiego merged 4 commits intodevelopfrom
omnichannel/fix-business-hour-error

Conversation

@renatobecker
Copy link
Copy Markdown
Contributor

@renatobecker renatobecker commented Jul 20, 2020

Proposed changes

Issue(s)

How to test or reproduce

  • Remove from the database a business hour associated with a department
  • Open the department
  • Look at the Network/XHR Tab on your browser console

Screenshots

Screen Shot 2020-07-20 at 16 31 35

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego merged commit 217c70e into develop Jul 21, 2020
@sampaiodiego sampaiodiego deleted the omnichannel/fix-business-hour-error branch July 21, 2020 01:44
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants