Skip to content

[FIX] View close uikit event sending wrong payload#18289

Merged
ggazzo merged 1 commit intodevelopfrom
fix/uikit-view-close-event
Jul 17, 2020
Merged

[FIX] View close uikit event sending wrong payload#18289
ggazzo merged 1 commit intodevelopfrom
fix/uikit-view-close-event

Conversation

@d-gubert
Copy link
Copy Markdown
Member

@d-gubert d-gubert commented Jul 17, 2020

Proposed changes

The viewClose interaction sent by the ui.interaction endpoint to the Apps-Engine was incorrect, sending both view and isClearedproperties asundefined` always.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@d-gubert d-gubert added this to the 3.5.0 milestone Jul 17, 2020
@ggazzo ggazzo merged commit 317cb2c into develop Jul 17, 2020
@d-gubert d-gubert deleted the fix/uikit-view-close-event branch July 17, 2020 20:29
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants