Conversation
ggazzo
force-pushed
the
feat/user-profile
branch
from
980c034 to
213237c
Compare
Co-authored-by: Tasso Evangelista <[email protected]>
| useUserSubscription: (rid: string, fields: Mongo.Query<any>) => any; | ||
| useUserSubscriptionByName: (name: string, fields: Mongo.Query<any>) => any; |
There was a problem hiding this comment.
Don't pass hooks through context. Pass subscriptions to be consumed by useSubscription (preferred) or reactive functions to be consumed by useReactiveValue.
There was a problem hiding this comment.
it will be fixed as regression :x
| }, [dispatchToastMessage, params, sendData, successMessage]); | ||
| }; | ||
|
|
||
| export const useEndpointActionExperimental = (httpMethod, endpoint, successMessage) => { |
There was a problem hiding this comment.
Maybe I missing something... In all use cases I've seen for this hook there was no reason to params to be called at the callback. E.g.:
const fn = useEndpointActionExperimental('POST', '/xyz');
const fnAction = useMutableCallback((...args) => {
fn(params, ...args);
});
When this would be better:
const fnAction = useEndpointAction('POST', '/xyz', params);
Co-authored-by: Tasso Evangelista <[email protected]>
… into feat/user-profile
Co-authored-by: Tasso Evangelista <[email protected]>
Co-authored-by: Tasso Evangelista <[email protected]>
tassoevan
added
area: ui/ux
|
Please add the ability to enable and disable the timezone from being shown in user profiles! |
|
Maybe I'm missing something and sorry if this is in the wrong place, but is it not possible to update the 'Bio' field shown on the profile card from the REAS API? Can't seem to find reference to this anywhere? Any pointers much appreciated. |
5 participants
closes #18219
closes #18243
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments